Improvement/cldsrv 553 bump deps #5711

benzekrimaha · 2024-12-06T14:42:38Z

bert-e · 2024-12-06T14:42:42Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-12-06T14:43:51Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-553 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.8.39

Please check the Fix Version/s of CLDSRV-553, or the target
branch of this pull request.

bert-e · 2024-12-12T14:04:51Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-553 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.9.0

Please check the Fix Version/s of CLDSRV-553, or the target
branch of this pull request.

francoisferrand · 2024-12-12T16:14:33Z

Dockerfile

@@ -1,4 +1,4 @@
-ARG NODE_VERSION=16.20.2-bookworm-slim
+ARG NODE_VERSION=22-bookworm-slim


should stick to a specific node version, to ensure reproductible & repeatable builds

francoisferrand · 2024-12-12T16:17:58Z

Dockerfile

+RUN npm install -g node-gyp
 COPY package.json yarn.lock /usr/src/app/
 RUN npm install [email protected] -g


best to install all "global" packages in a single step,
before package.json copy (to avoid invalidatoin),
and specifying the node-gyp version (just like we do for typescript)

Suggested change

RUN npm install -g node-gyp

COPY package.json yarn.lock /usr/src/app/

RUN npm install [email protected] -g

RUN npm install -g \

[email protected] \

[email protected]

COPY package.json yarn.lock /usr/src/app/

francoisferrand · 2024-12-12T16:19:59Z

lib/api/apiUtils/authorization/prepareRequestContexts.js

@@ -154,13 +154,6 @@ function prepareRequestContexts(apiMethod, request, sourceBucket,
                generateRequestContext('objectPutTaggingVersion');
            requestContexts.push(putObjectVersionRequestContext);
        }


why are we changing permissions?
if it was (already) a bug, it shoudl be fixed on 8.8 as well instead here...

bert-e · 2024-12-12T16:29:23Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

lib/Config.js

lib/utapi/utilities.js

francoisferrand · 2024-12-12T16:42:47Z

.github/workflows/tests.yaml

@@ -342,39 +342,6 @@ jobs:
        source: /tmp/artifacts
      if: always()



should be skipped instead of removed:

Suggested change

utapi-v2-tests:

if: false

francoisferrand · 2024-12-18T13:47:16Z

please rebase, there are conflicts.
(sorry, add some pending commensts, which may not be relevant anymore : please with this in mind...)

francoisferrand · 2024-12-18T13:48:51Z

bin/list_metrics.js

@@ -1,4 +0,0 @@
-#!/usr/bin/env node


should keep this file, and just add early return (if needed) in listMetrics()

francoisferrand · 2024-12-18T13:48:58Z

bin/list_bucket_metrics.js

-#!/usr/bin/env node
-'use strict'; // eslint-disable-line strict
-
-require('../lib/utapi/utilities.js').listMetrics('buckets');


should keep this file, and just add early return (if needed) in listMetrics()

Issue: CLDSRV-553

This reverts commit a20bc5d.

bert-e · 2024-12-20T07:58:50Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

codecov · 2024-12-20T09:09:12Z

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.30%. Comparing base (11b978b) to head (0443802).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/utapi/utilities.js	25.00%	3 Missing ⚠️
lib/Config.js	66.66%	2 Missing ⚠️
lib/utapi/utapi.js	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
bin/create_bucket_with_NFS_enabled.js	`0.00% <ø> (ø)`
bin/create_encrypted_bucket.js	`0.00% <ø> (ø)`
bin/list_bucket_metrics.js	`0.00% <ø> (ø)`
bin/list_metrics.js	`0.00% <ø> (ø)`
bin/metrics_server.js	`0.00% <ø> (ø)`
bin/search_bucket.js	`0.00% <ø> (ø)`
bin/secure_channel_proxy.js	`0.00% <ø> (ø)`
lib/api/api.js	`0.00% <ø> (ø)`
lib/api/apiUtils/authorization/permissionChecks.js	`87.59% <ø> (ø)`
...i/apiUtils/authorization/prepareRequestContexts.js	`92.43% <ø> (+2.92%)`	⬆️
... and 28 more

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.0    #5711      +/-   ##
===================================================
- Coverage            60.56%   60.30%   -0.26%     
===================================================
  Files                  185      183       -2     
  Lines                11619    11602      -17     
===================================================
- Hits                  7037     6997      -40     
- Misses                4582     4605      +23

Flag	Coverage Δ
unit	`60.30% <83.33%> (-0.26%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

benzekrimaha force-pushed the improvement/CLDSRV-553-bump-deps branch from dcc7c34 to 0eadb81 Compare December 6, 2024 15:59

francoisferrand changed the base branch from development/8.8 to development/8.9 December 12, 2024 14:04

francoisferrand reviewed Dec 12, 2024

View reviewed changes

benzekrimaha force-pushed the improvement/CLDSRV-553-bump-deps branch 2 times, most recently from 15b93ac to 57325de Compare December 12, 2024 16:26

benzekrimaha marked this pull request as ready for review December 12, 2024 16:26

benzekrimaha force-pushed the improvement/CLDSRV-553-bump-deps branch from 57325de to 2639bf6 Compare December 12, 2024 16:29

scality deleted a comment from bert-e Dec 12, 2024

benzekrimaha force-pushed the improvement/CLDSRV-553-bump-deps branch from 8bb9b0a to b5e6e01 Compare December 12, 2024 16:49

francoisferrand reviewed Dec 18, 2024

View reviewed changes

benzekrimaha added 11 commits December 20, 2024 08:57

Bump dependencies

7bfe32a

Issue: CLDSRV-553

Adapt docker file

48b4a6a

Issue: CLDSRV-553

Adapt config post bump eslint to v9

8e6a32f

Issue: CLDSRV-553

Update code to match scality guidelines

a942098

Issue: CLDSRV-553

Md lint fixup

5b2d51c

Issue: CLDSRV-553

Adapt package.json mocha tests commands

1f72d50

Issue: CLDSRV-553

Tests fixups post bump failures

6522b62

Issue: CLDSRV-553

Bump node version in gha

b60f93f

Issue: CLDSRV-553

Skipping tests not working

f1fdb1c

Issue: CLDSRV-553

Revert "[to be reverted]utapi removal"

f03db55

This reverts commit a20bc5d.

test

f1a4f29

benzekrimaha added 2 commits December 20, 2024 08:58

fixup

7fb46f3

pot review docker file fixup

bc7b54f

benzekrimaha force-pushed the improvement/CLDSRV-553-bump-deps branch from 699b1d4 to bc7b54f Compare December 20, 2024 07:58

scality deleted a comment from bert-e Dec 20, 2024

benzekrimaha added 4 commits December 20, 2024 09:00

fixup

f92e7e3

fixup

43ba749

fixup

06b308c

fixup

0443802

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/cldsrv 553 bump deps #5711

Improvement/cldsrv 553 bump deps #5711

benzekrimaha commented Dec 6, 2024 •

edited

Loading

bert-e commented Dec 6, 2024

bert-e commented Dec 6, 2024

bert-e commented Dec 12, 2024

francoisferrand Dec 12, 2024 •

edited

Loading

francoisferrand Dec 12, 2024

francoisferrand Dec 12, 2024

bert-e commented Dec 12, 2024

francoisferrand Dec 12, 2024

francoisferrand commented Dec 18, 2024

francoisferrand Dec 18, 2024

francoisferrand Dec 18, 2024

bert-e commented Dec 20, 2024

codecov bot commented Dec 20, 2024 •

edited

Loading

		@@ -1,4 +1,4 @@
		ARG NODE_VERSION=16.20.2-bookworm-slim
		ARG NODE_VERSION=22-bookworm-slim

		@@ -342,39 +342,6 @@ jobs:
		source: /tmp/artifacts
		if: always()

Improvement/cldsrv 553 bump deps #5711

Are you sure you want to change the base?

Improvement/cldsrv 553 bump deps #5711

Conversation

benzekrimaha commented Dec 6, 2024 • edited Loading

bert-e commented Dec 6, 2024

Hello benzekrimaha,

bert-e commented Dec 6, 2024

Incorrect fix version

bert-e commented Dec 12, 2024

Incorrect fix version

francoisferrand Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

francoisferrand Dec 12, 2024

Choose a reason for hiding this comment

francoisferrand Dec 12, 2024

Choose a reason for hiding this comment

bert-e commented Dec 12, 2024

Waiting for approval

francoisferrand Dec 12, 2024

Choose a reason for hiding this comment

francoisferrand commented Dec 18, 2024

francoisferrand Dec 18, 2024

Choose a reason for hiding this comment

francoisferrand Dec 18, 2024

Choose a reason for hiding this comment

bert-e commented Dec 20, 2024

Waiting for approval

codecov bot commented Dec 20, 2024 • edited Loading

Codecov Report

benzekrimaha commented Dec 6, 2024 •

edited

Loading

francoisferrand Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading