Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProgressBar): prefix, suffix and max #4509

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

<ProgressBar />: new props max, prefix and suffix

@lisalupi lisalupi requested a review from a team November 27, 2024 13:06
@lisalupi lisalupi self-assigned this Nov 27, 2024
@lisalupi lisalupi requested review from BABAK0T0 and removed request for a team November 27, 2024 13:06
@lisalupi lisalupi requested a review from matthprost as a code owner November 27, 2024 13:06
@lisalupi lisalupi requested a review from Lawndlwd November 27, 2024 13:06
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: a5013b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (e11aa60) to head (a5013b0).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4509      +/-   ##
==========================================
+ Coverage   87.51%   87.55%   +0.04%     
==========================================
  Files         335      335              
  Lines       12762    12780      +18     
  Branches     3510     3518       +8     
==========================================
+ Hits        11169    11190      +21     
+ Misses       1593     1590       -3     
Files with missing lines Coverage Δ
...rc/components/ProgressBar/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/ProgressBar/index.tsx 100.00% <100.00%> (+6.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e42097...a5013b0. Read the comment docs.

Copy link
Contributor

@vincentaudebert vincentaudebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to have a quick screenshot of what the component looks like just to be sure 🙏

@lisalupi lisalupi force-pushed the feat/progress-bar-max branch from 1a7a85c to a5013b0 Compare December 11, 2024 10:00
@lisalupi lisalupi merged commit ffb2c06 into main Dec 11, 2024
13 checks passed
@lisalupi lisalupi deleted the feat/progress-bar-max branch December 11, 2024 10:14
@scaleway-bot scaleway-bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants