-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ProgressBar): prefix, suffix and max #4509
Conversation
🦋 Changeset detectedLatest commit: a5013b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4509 +/- ##
==========================================
+ Coverage 87.51% 87.55% +0.04%
==========================================
Files 335 335
Lines 12762 12780 +18
Branches 3510 3518 +8
==========================================
+ Hits 11169 11190 +21
+ Misses 1593 1590 -3
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice to have a quick screenshot of what the component looks like just to be sure 🙏
1a7a85c
to
a5013b0
Compare
Summary
Type
Summarise concisely:
What is expected?
<ProgressBar />
: new propsmax
,prefix
andsuffix