Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectInputV2): dropdown to be at least 320px #4373

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

To set minimum of 320px on select input v2

Relevant logs and/or screenshots

Page Before After
url Screenshot 2024-10-21 at 14 34 16 Screenshot 2024-10-21 at 14 34 22

@matthprost matthprost added the enhancement New feature or request label Oct 21, 2024
@matthprost matthprost self-assigned this Oct 21, 2024
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: f796096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.82%. Comparing base (7376580) to head (f796096).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4373   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files         316      316           
  Lines       11593    11593           
  Branches     3215     3174   -41     
=======================================
  Hits        10066    10066           
  Misses       1527     1527           
Files with missing lines Coverage Δ
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 43.77% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7376580...f796096. Read the comment docs.

@matthprost matthprost merged commit 291882b into main Oct 24, 2024
12 checks passed
@matthprost matthprost deleted the fix/select-input-dropdown branch October 24, 2024 09:24
@scaleway-bot scaleway-bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants