-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectInputV2): various improvements #4339
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: e83de16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4339 +/- ##
=======================================
Coverage ? 86.61%
=======================================
Files ? 316
Lines ? 11599
Branches ? 3209
=======================================
Hits ? 10047
Misses ? 1552
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
packages/ui/src/components/SelectInputV2/__stories__/EmptyState.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/SelectInputV2/__stories__/Searchable.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more comments to add, I'm not super legit to approve but here is mine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe wait for me to come back from vacation to merge this one as there will be nobody to fix in case of issue 😅
Summary
Type
Summarise concisely:
What is expected?
<SelectInputV2 />
:searchable = true
)footer
to close the dropdownclearable = false
by default nowThe following changes were made: