Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectInputV2): resize issue in a modal #4291

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix <SelectInputV2 /> resize issue in a modal

Relevant logs and/or screenshots

Page Before After
url Screenshot 2024-09-30 at 09 04 17 Screenshot 2024-09-30 at 09 13 36

@matthprost matthprost added the bug Something isn't working label Sep 30, 2024
@matthprost matthprost self-assigned this Sep 30, 2024
Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: f3579e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@331e3b4). Learn more about missing BASE report.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4291   +/-   ##
=======================================
  Coverage        ?   87.00%           
=======================================
  Files           ?      315           
  Lines           ?    11458           
  Branches        ?     3109           
=======================================
  Hits            ?     9969           
  Misses          ?     1489           
  Partials        ?        0           
Files with missing lines Coverage Δ
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 41.86% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331e3b4...f3579e4. Read the comment docs.

@matthprost matthprost merged commit 9c722d7 into main Sep 30, 2024
11 checks passed
@matthprost matthprost deleted the fix/select-input-resize branch September 30, 2024 07:33
@scaleway-bot scaleway-bot mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants