Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Snippet): rows and scroll #4249

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat(Snippet): rows and scroll #4249

merged 3 commits into from
Sep 24, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Enhancement

Summarise concisely:

new props rows (number) to define the max number of rows to show and noExpandable (boolean) to control show/hide option

@lisalupi lisalupi added the enhancement New feature or request label Sep 17, 2024
@lisalupi lisalupi requested review from matthprost and a team September 17, 2024 09:29
@lisalupi lisalupi self-assigned this Sep 17, 2024
@lisalupi lisalupi requested review from vincentaudebert and removed request for a team September 17, 2024 09:29
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 1675c31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c1f576e). Learn more about missing BASE report.
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4249   +/-   ##
=======================================
  Coverage        ?   87.00%           
=======================================
  Files           ?      315           
  Lines           ?    11369           
  Branches        ?     3074           
=======================================
  Hits            ?     9892           
  Misses          ?     1477           
  Partials        ?        0           
Files with missing lines Coverage Δ
...ui/src/components/Snippet/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Snippet/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f576e...1675c31. Read the comment docs.

packages/ui/src/components/Snippet/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Snippet/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Snippet/index.tsx Show resolved Hide resolved
@matthprost matthprost merged commit 4e2e5b5 into main Sep 24, 2024
11 checks passed
@matthprost matthprost deleted the feat/snipper-max-rows branch September 24, 2024 13:39
@scaleway-bot scaleway-bot mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants