-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency react-datepicker to v7 #3907
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4d1b842 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
74b8e29
to
ac08e1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are refactoring this one may be we can delay the update ?
ac08e1e
to
4bf6cc9
Compare
This update kinda destroyed the types especially on onChange prop, there is an open issue here: Hacker0x01/react-datepicker#4924 I'm facing the same problem :/ |
4bf6cc9
to
1bb7c40
Compare
|
||
const localeCode = | ||
(typeof locale === 'string' ? locale : locale?.code) ?? 'en-GB' | ||
const localeCode = (typeof locale === 'string' ? locale : locale) ?? 'en-GB' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to check why they remove the code of locale?.code in the type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Alexandre Philibeaux <[email protected]>
94bc59e
to
4d1b842
Compare
This PR contains the following updates:
6.9.0
->7.1.0
Release Notes
Hacker0x01/react-datepicker (react-datepicker)
v7.1.0
: 7.1.0Compare Source
What's Changed
Full Changelog: Hacker0x01/react-datepicker@v7.0.0...v7.1.0
v7.0.0
: 7.0.0Compare Source
Breaking changes
This release includes a Typescript migration. This has been a big overhaul of the code base. This is the biggest release ever with 447 commits and 104 files changed! Massive thanks to @mirus-ua, @yuki0410-dev, @Olenka-Yurchuk, @alvaromartinez986, and @ryantanrk. We've done our best to document the breaking changes:
What's Changed
New Contributors
Full Changelog: Hacker0x01/react-datepicker@v6.9.0...v7.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.