This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
feat!: new @scalar/openapi-types
package
#175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c955c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#141 Bundle Size — 74.91KiB (0%).5c955c8(current) vs aec9f22 main#137(baseline) Bundle metrics
|
Current #141 |
Baseline #137 |
|
---|---|---|
Initial JS | 74.91KiB |
74.91KiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 0% |
0% |
Chunks | 45 |
45 |
Assets | 45 |
45 |
Modules | 45 |
45 |
Duplicate Modules | 0 |
0 |
Duplicate Code | 0% |
0% |
Packages | 0 |
0 |
Duplicate Packages | 0 |
0 |
Bundle analysis report Branch feat/new-types-package Project dashboard
Generated by RelativeCI Documentation Report issue
Deploying openapi-parser with Cloudflare Pages
|
amritk
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sick!
hanspagel
changed the title
feat: new
feat!: new Aug 9, 2024
@scalar/openapi-types
package@scalar/openapi-types
package
hey @hanspagel we are going to move the types into the monorepo so I'll copy them over, then there should be no breaking changes here. We can also just re-export them after for a single source of truth |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modified and extended the
openapi-types
package for our use case. We’re basically allowing any user input, but still maintaining the types based on the OpenAPI specification.With this PR, we’re exposing those types as a separate, dependency-free package called
@scalar/openapi-types
. Even comes with basic type tests. :)Note: This is a breaking change. Instead of importing types from
@scalar/openapi-parser
, users now have to import from@scalar/openapi-types
.Usage
And use it like this: