Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plugin sbt-version-policy-dynver #195

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Add new plugin sbt-version-policy-dynver #195

merged 9 commits into from
Jan 15, 2024

Conversation

alejandrohdezma
Copy link
Contributor

💻 How to review this PR?

This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.

I also recommend checking "Hide whitespace" when reviewing this PR!

🚀 What's included in this PR?

📦 Build changes

  • Enable using the plugin directly on its own build, instead of using the latest version.
  • Add sbt-modules to the build to allow creating SBT sub-projects under modules by default and provide some other "goodies" like deactivating publishing for anything that is not a sub-module (no need for explicit root module).
  • Adds a few fixes to GHA CI files.

✨ New sbt-version-policy-dynver plugin

A new module containing a plugin has been added to the build. This plugin just enables...

versionPolicyIgnoredInternalDependencyVersions := Some("^\\d+\\.\\d+\\.\\d+\\+\\d+".r)

...at the build level as stated in the "DynVer" section of the README to reduce boilerplate of libraries's build files that are using this plugin.

@julienrf
Copy link
Collaborator

Hello, thank you for your help @alejandrohdezma!

However, I am not sure creating a new plugin for one setting is worth it, to be honest. I prefer having just sbt-version-policy. That being said, some of the changes of your PR would be very welcome:

Would you be interested in submitting only those changes?

…without polluting dependent builds"

This reverts commit b184bfd.
This reverts commit fc2e905.

# Conflicts:
#	project/plugins.sbt
@alejandrohdezma
Copy link
Contributor Author

Hello, thank you for your help @alejandrohdezma!

However, I am not sure creating a new plugin for one setting is worth it, to be honest. I prefer having just sbt-version-policy. That being said, some of the changes of your PR would be very welcome:

Would you be interested in submitting only those changes?

Hey @julienrf, sure, I just reverted the other 3 commits.

@julienrf julienrf merged commit 276df09 into scalacenter:main Jan 15, 2024
2 checks passed
@julienrf
Copy link
Collaborator

Thank you!

huajiang-tubi pushed a commit to adRise/sbt-version-policy that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants