-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Alignment of Restrict Bounding Box Button #8388
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis update introduces a new button within the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/javascripts/oxalis/view/action-bar/toolbar_view.tsx (1)
1381-1386
: Consider extracting the button style to a constant.For better maintainability and consistency with other styles in the file (like
NARROW_BUTTON_STYLE
), consider extracting the button's style object to a constant.+const FLOOD_FILL_BUTTON_STYLE = { + opacity: 0.5, + marginLeft: 12, + display: "inline-block", +}; <ButtonComponent - style={{ - opacity: isRestrictedToBoundingBox ? 1 : 0.5, - marginLeft: 12, - display: "inline-block", - }} + style={{ + ...FLOOD_FILL_BUTTON_STYLE, + opacity: isRestrictedToBoundingBox ? 1 : 0.5, + }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/javascripts/oxalis/view/action-bar/toolbar_view.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: circleci_build
🔇 Additional comments (1)
frontend/javascripts/oxalis/view/action-bar/toolbar_view.tsx (1)
1384-1384
: LGTM! The display style fix improves button alignment.The change to use
display: "inline-block"
ensures proper alignment of the "Restrict Bounding Box" button within the toolbar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)