-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions section #79
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey I think these are awesome!!! I wonder if we can integrate Carlos' changes into this somehow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm Eda!! This is looking great! Just added a couple of comments but lets see what have others have to say too 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @edakturk14 ! Looking great to me! Added two small nitpicks
These are great @portdeveloper, @technophile-04, @rin-st - thank you so much!! I've made the changes and a few more edits. Lmk what you think. Open question -- should we add some of the examples for extensions which people can develop (eg: ERC721 / ERC1155) -- as in the comment from carlos which port mentioned above. Here is how it could look like: (it could go in the 3rd party extensions section) Extension IdeasHere are some potential extension ideas you could explore:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job putting this together @edakturk14 !! ✨
Just checked the latest version and left some comments, mostly nitpicks that can be ignored if you don't feel them necessary 🙏
perfect, @Pabl0cks thank you!! added the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the quick updates Eda!! Looks good to me 🙌
We can always iterate if people finds something confusing.
should we add some of the examples for extensions which people can develop (eg: ERC721 / ERC1155) -- as in the comment from carlos which port mentioned above.
I don't have a strong opinion there, it's already in the hackathon FAQ and pinned in TG, maybe is not needed here, but wouldn't hurt either (at least while hackathon submission period is open?). If we decide to add it, could always go in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm Eda!! Looking great!
hey @Pabl0cks, @technophile-04 - as per #75, here's an initial extensions section.
Lmk what you think, happy to make any changes + additions as needed!