Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify section to add hardhat-verify method #50

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

Pabl0cks
Copy link
Collaborator

@Pabl0cks Pabl0cks commented Jan 9, 2024

I've modified the verify section to incorporate both methods, suggesting current method as default.

Not sure if the description for each method is totally accurate. Tried to complement it with links to the docs of each one.

Let me know if you would change anything 🙌

Closes #49

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffold-eth-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 11:27pm

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm Pablo looks great! Just an alternative that I had in mind :


4. Verify your smart contract

You can verify your smart contract on Etherscan by running:

yarn verify --network network_name

eg: yarn very --network sepolia

This uses etherscan-verify from hardhat-deploy to verify all the deployed contracts.

You can alternatively also use hardhat-verify to verify your contracts by running yarn hardhat-verify --network network_name contract_address

If the chain you're using is not supported by any of the verifying methods, you can add new supported chains to your choosen method, either etherscan-verify or hardhat-verify .


Just tired keeping it kind of less opinionated and inline with other sections,

But your version also looks coo !! and we can merge it as it is !!! Really love the addition of last paragraph ( If the chain you're ... ) and links super helpful!!

@Pabl0cks
Copy link
Collaborator Author

Tysm Pablo looks great! Just an alternative that I had in mind :

Thanks for the suggestion! Initially I didn't put the bullet points, but then changed to that version. I pushed your approach for now, I like giving yarn verify more importance with your approach 🙌

Merging it! We can change it in the future if we want to give similar weight to each method, in case hardhat-verify adds more useful features.

@Pabl0cks Pabl0cks merged commit dc5cc9b into main Jan 10, 2024
3 checks passed
@Pabl0cks Pabl0cks deleted the update/contract-verify-section branch January 10, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contract verify section
2 participants