-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pooling interval to EventHistory hook #597
Conversation
Hey @damianmarti , thanks for this!! I always have to use the history hook + subscriber hook to get this behavior. So this might be better & simpler! So we have (Just thinking out loud) |
Makes sense!! Changed! Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works great! Thanks all!
Now I guess there is some overlapping happening between useScaffoldEventHistory & useScaffoldEventSubscriber.
I'll create an issue or PR in the docs repo!
Created PR here: scaffold-eth/se-2-docs#38 |
Description
Add a new poolingInterval optional parameter to useScaffoldEventHistory to be able to get the new events.
If we merge this PR, I will open a PR to update the doc.
Additional Information
Your ENS/address: damianmarti.eth