Skip to content

Conversation

@scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Nov 26, 2025

About this PR

πŸ“¦ Updates org.scala-lang:scala-compiler from 2.13.16 to 2.13.18

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (2.13.16).
You might want to review and update them manually.

internal/zinc-core/src/main/scala/sbt/internal/inc/RootPath.scala
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-compiler" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-compiler" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@mkurz
Copy link
Member

mkurz commented Dec 1, 2025

How can the failing tests be fixed?

$ grep -r --exclude-dir=.git --exclude-dir=target '2\.13\.1'
internal/zinc-benchmarks/src/test/scala/xsbt/ZincBenchmark.scala:  val scalaVersion = "2.13.18"
internal/compiler-bridge-test/src/test/scala/sbt/internal/inc/CompilingSpecification.scala:  def scala213 = "2.13.18"
project/Dependencies.scala:  val scala213 = "2.13.18"
project/Dependencies.scala:  val scala213ForBridge = "2.13.18"

I can not see were 2.13.16 can be bumped.
I guess some external dep needs to be updated? Or sbt itsel needs to bump to 2.13.18 before?

@eed3si9n
Copy link
Member

How can the failing tests be fixed?

I think in theory the diff should have worked? Bumping to 2.13.16 was automatic - #1530. Also given that Scala 2.13 has in-sourced the bridge implementation, I'm also not sure if we should bump the 2.13 version used to test our bridge implementation.

@scala-steward scala-steward force-pushed the update/scala-compiler-2.13.18 branch from e48adb5 to 5ac1f01 Compare December 14, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants