Don't close URLClassLoader #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
leave-cl-open
branch
from
ae2931b to
6b17517
Compare
Closing the URLClassLoader seems to create an issue due to concurrency nature of sbt. When another ClassLoader accesses a resource, the stream is closed unexpectedly. Change schema logging to better represent concurrent execution.
RustedBones
force-pushed
the
leave-cl-open
branch
from
6b17517 to
b682f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the URLClassLoader seems to create an issue due to concurrency nature of sbt. When another ClassLoader accesses a resource, the stream is closed unexpectedly.
Change schema logging to better represent concurrent execution.