Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockit): Prevent php warnings #1028

Open
wants to merge 1 commit into
base: php81
Choose a base branch
from
Open

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Dec 7, 2024

Description

  • Uncommented and fixed the database query to get server data and prevent php warnings for $data
  • Added null coalescing operator for hostname array access

Motivation and Context

PHP Warning: Undefined variable $sdata in /var/www/vhosts/nide.gg/bans.nide.gg/pages/admin.blockit.php on line 91;
PHP message: PHP Warning: Trying to access array offset on null in /var/www/vhosts/nide.gg/bans.nide.gg/pages/admin.blockit.php on line 91; 

But I wonder why @Hackmastr commented this part of the code in smart v5 changes.

How Has This Been Tested?

Applied fix and run the page with an url like bans.nide.gg/pages/admin.blockit.php?check=steam_0:1:802859631&type=1&length=60 and do not throw warnings anymore.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

- Uncommented and fixed the database query to get server data and prevent php warnings for $data
- Added null coalescing operator for hostname array access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant