[Fix] Rewrite encoding in TransformersEmbedder
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsz05
changed the title
TransformersEmbedder
…an the number of processes in order to prevent bug
…mers_embedder_encoding
[dev to main] v1.3.1
[dev to main] v1.3.1 hot fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今までの
TransformersEmbedderのエンコードメソッドでは独自のバッチ化をしているため，マルチGPUの場合，二重のバッチ分割によりバグを起こりやすいという問題点があります。また，マルチGPUの場合，バッチサイズがGPU数の整数倍ではないと（例えば，batch size = 4, n_gpu = 8）data parallelがうまくいかない可能性があり，バッグりやすいです。関連する Issue / PR
N/A
PR をマージした後の挙動の変化
TransformersEmbedderが独自のbatch_encode_with_cacheを持つようにし，二重のバッチ分割を解消TransformersEmbedderのembedding出力を全てtorch.Tensorとし，np.numpyをやめるTransformersEmbedderにおいて，マルチGPUの場合，バッチサイズがプロセス数の整数倍でなければエラーを出す挙動の変更を達成するために行ったこと
TransformersEmbedderのエンコードメソッドをリファクタリングした動作確認