-
Notifications
You must be signed in to change notification settings - Fork 61
[SOL-19] Removing the archetypes (eventually they'll go elsewhere) #97
base: master
Are you sure you want to change the base?
Conversation
@mmerrell-sauce this might've gotten a bit stale. We've seen people trying to use the TestNG archetype and by extension the testng artifact (link) which iirc is deprecated. |
We have a new Java framework that should drop sometime soon. I hope to include a new archetype with that. If the people using the current one are able to get it to run successfully, I think we should keep it alive--it's not the best way to get tests working, but it's not the worst. I think removing it before we have a replacement ready would create more frustration. Let me know what you think. |
@mmerrell main issue here is that the archetype uses the sauce_testng module that was deprecated a bit ago I don't think we should be encouraging a sample archetype that uses code we no longer consider valid. |
@enriquegh did this ever get resolved? If not, what do you propose that we do? |
@nadvolod don't believe so.
I'm good with either and happy to make a PR for either if needed. |
@enriquegh I like the removal. Might be the fastest way to solve the problem. If you can send a PR, would be great 👍 |
@nikolay-advolodkin @mmerrell-sauce I've rebased this PR with master and did a small addition to Marcus' original work. The Travis' tests seem to have all failed but based on Travis history these haven't been working for a while? Best I can tell they're not failing because of the changes done here. If you'd like me to look into them let me know but I think those might be a PR on its own. |
I'm working on an archetype for the more up-to-date samples, and they belong with the sample frameworks, not in this project