Skip to content

Conversation

@tmoody
Copy link
Member

@tmoody tmoody commented Dec 9, 2025

Issue

  1. 2 npm test results end in failure due to a missing dependency in each of those tests.

  2. A third test fails in a Windows environment after base64 encoding of an .svg file returns a different result.

Intent

  1. Introduce the missing 'mfv_getpathuri.sas dependency that was returned by the tested function, but not recorded in the 'expected' results.

  2. Allow the Windows test to consider a match with either of 2 results instead of a singular result.

Implementation

  1. src/sasCli/specs/getDependencyPaths.spec.ts amended in 2 lists to include the missing dependency.

  2. The comparison data for the encoded image test is now stored in a list array and the test for it is now changed from equality to accepting whether the array contains the result.

Run npm test to ensure success:

...
Test Suites: 37 passed, 37 total
Tests:       419 passed, 419 total
Snapshots:   0 total
Time:        9.622 s
Ran all test suites.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
  • All sasjs-cli unit tests are passing (npm test).
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@tmoody tmoody self-assigned this Dec 9, 2025
@allanbowe allanbowe requested a review from medjedovicm December 9, 2025 22:51
@allanbowe allanbowe merged commit 2c3de2f into main Dec 10, 2025
4 checks passed
@allanbowe allanbowe deleted the fixBrokenJests branch December 10, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants