fix(test): added missing dependency to failing tests #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
2
npm testresults end in failure due to a missing dependency in each of those tests.A third test fails in a Windows environment after base64 encoding of an
.svgfile returns a different result.Intent
Introduce the missing
'mfv_getpathuri.sasdependency that was returned by the tested function, but not recorded in the 'expected' results.Allow the Windows test to consider a match with either of 2 results instead of a singular result.
Implementation
src/sasCli/specs/getDependencyPaths.spec.tsamended in 2 lists to include the missing dependency.The comparison data for the encoded image test is now stored in a list array and the test for it is now changed from equality to accepting whether the array contains the result.
Run
npm testto ensure success:Checks
npm run lint:fix).npm test).sasjs-cliunit tests are passing (npm test).Reviewer checks