Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: better doc for CreateFile and mark parameter unused #835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinburkesegment
Copy link

@kevinburkesegment kevinburkesegment commented Aug 27, 2024

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.

Describe the change

The first time I read this I wasn't sure how exactly the API was
receiving the file contents, so I added extra documentation to make
this more clear.

Tests
Shouldn't need tests as these are only documentation changes.

Additional context
Add any other context or screenshots or logs about your pull request here. If the pull request relates to an open issue, please link to it.

Issue: #XXXX

The first time I read this I wasn't sure how exactly the API was
receiving the file contents, so I added extra documentation to make
this more clear.
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (774fc9d) to head (8f2dd32).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   98.46%   99.01%   +0.55%     
==========================================
  Files          24       26       +2     
  Lines        1364     1418      +54     
==========================================
+ Hits         1343     1404      +61     
+ Misses         15        8       -7     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant