Test Harbor+ghcr.io error code special handling #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
force-pushed
the
test-habor
branch
from
9273415 to
cde204f
Compare
majewsky
changed the title
SuperSandro2000
force-pushed
the
test-habor
branch
from
cde204f to
a7d49e8
Compare
SuperSandro2000
force-pushed
the
test-habor
branch
from
a7d49e8 to
1d9030f
Compare
majewsky
requested changes
Jan 14, 2026
internal/client/auth_challenge.go
Outdated
Comment on lines
115
to
118
| var errStr strings.Builder | ||
| for _, e := range data.Errors { | ||
| errStr.WriteString(e.Error() + "; ") | ||
| } |
Contributor
There was a problem hiding this comment.
This produces an extra trailing "; " at the end. Please use errext.ErrorSet and then errs.Join("; ").
SuperSandro2000
force-pushed
the
test-habor
branch
from
d56dab0 to
6be8176
Compare
Co-authored-by: Stefan Majewsky <[email protected]> (cherry picked from commit d56dab0)
SuperSandro2000
force-pushed
the
test-habor
branch
from
6be8176 to
3bd6f12
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
majewsky
approved these changes
Jan 14, 2026
majewsky
added a commit
that referenced
this pull request
Jan 15, 2026
fix regression introduced in #633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.