[pgbackup] add option to use db_region to fix limes in global #8492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnerd3
requested review from
Nuckal777,
SuperSandro2000,
VoigtS and
majewsky
as code owners
Contributor
Contributor
|
Please rebase. We merged another PR that bumped the pgbackup version number, thus causing a merge conflict. |
wagnerd3
force-pushed
the
fix_pgbackup_for_global_region
branch
from
3b60721 to
61d500a
Compare
Contributor
wagnerd3
force-pushed
the
fix_pgbackup_for_global_region
branch
from
61d500a to
5334e96
Compare
Contributor
wagnerd3
force-pushed
the
fix_pgbackup_for_global_region
branch
from
5334e96 to
9aabf75
Compare
Contributor
wagnerd3
force-pushed
the
fix_pgbackup_for_global_region
branch
from
9aabf75 to
78b1063
Compare
majewsky
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
globalregion, it is necessary to distinguish the "virtual region" (global) from the real region where the db is running and to be backed up (which has e.g. a storage service available). We already introduced the variable but this should be downwards compatible for all usecases where the$REGION/values/globals.yamlis not used.