Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Covers position and target level #11

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Fix Covers position and target level #11

merged 4 commits into from
Mar 2, 2024

Conversation

slajob
Copy link
Collaborator

@slajob slajob commented Mar 1, 2024

Hi, I make some fixes to make it working. I tested it on my KADRILJ roller blind

  1. Covers level
    Current_cover_position is a integer so it's not callable.
  File "/workspaces/core/custom_components/dirigera_platform/cover.py", line 95, in current_cover_position
    return self._json_data.attributes.blinds_current_level()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'int' object is not callable
  1. Covers control attribute
    Changed set_target_position attribute to set_target_level.
  File "/workspaces/core/custom_components/dirigera_platform/cover.py", line 136, in set_cover_position
    print(self._json_data.set_target_position(position))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Blind' object has no attribute 'set_target_position'

@sanjoyg sanjoyg merged commit 1156f99 into sanjoyg:main Mar 2, 2024
3 checks passed
@sanjoyg
Copy link
Owner

sanjoyg commented Mar 2, 2024

Thank you @slajob, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants