feat(types): add VideoSubtitleInfo types to playback info#1191
Draft
feat(types): add VideoSubtitleInfo types to playback info#1191
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
- Add VideoSubtitleInfoPublic, VideoSubtitleInfoSigned, and VideoSubtitleInfo union type for subtitle tracks - Add subtitles field to VideoPlaybackInfo interface - Re-export subtitle types from media-library entry point Co-Authored-By: Claude <noreply@anthropic.com>
sjelfull
force-pushed
the
dam-video-subtitle-types
branch
from
327989f to
ff01a0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds subtitle type definitions for the video playback info response, split out from #1186 (renditions PR) to keep concerns separate.
Types added
VideoSubtitleInfoPublic— trackId, languageCode, urlVideoSubtitleInfoSigned— extends public with token + expiresAtVideoSubtitleInfo— union typesubtitles?: VideoSubtitleInfo[]field onVideoPlaybackInfoRe-exported from
@sanity/client/media-library.