-
Notifications
You must be signed in to change notification settings - Fork 35
feat: add support for new listener events #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bjoerge
wants to merge
5
commits into
main
Choose a base branch
from
cldx-4262/new-listener-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
mwain
reviewed
Nov 6, 2025
a72baa6 to
a90cf67
Compare
commit: |
a90cf67 to
abf3db3
Compare
abf3db3 to
62f8b49
Compare
d21fd60 to
353a269
Compare
sgulseth
previously approved these changes
Nov 19, 2025
mwain
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This enableResume is currently only available on vX so this is not ready to be merged yet, but otherwise it's ready for review.
Description
Adds
enableResume: booleantoListenerOptions. This instructs the listen-endpoint to push down events based on theLast-Event-Idheader, and adds two more listener events:welcomeback– when the listener has reconnected successfully. This event is emitted immediately when listener has successfully reconnected, and any resumed mutation events will arrive after.reset– signals that listener can't resume events. Consumers should respond to this event by resetting local state.What to review
Testing
Unit tests added.