View individual sub-pools of the multi-pool#2612
Open
dasunpubudumal wants to merge 26 commits intodevelopfrom
Open
View individual sub-pools of the multi-pool#2612dasunpubudumal wants to merge 26 commits intodevelopfrom
dasunpubudumal wants to merge 26 commits intodevelopfrom
Conversation
dasunpubudumal
changed the base branch from
develop
to
Y25-475-flexible-pool-page
…nd modify FlexibleIndividualPoolCreate integration
… PacbioPoolEdit component
…, updates router setup
BenTopping
reviewed
Feb 3, 2026
…ems in store and component
…utes in favour of using existing pacbioPool payload method
feat(multi-pool): add update functionality for multi pool position it…
… navigate to dashboard
BenTopping
requested changes
Feb 24, 2026
Contributor
BenTopping
left a comment
BenTopping
left a comment
There was a problem hiding this comment.
Looking good, nice work 👌 Couple minor comments and questions.
| @aliquot-selected="notifyAliquotSelection" | ||
| /> | ||
| <div class="text-right py-8"> | ||
| <div v-if="!props.flexiblePoolPosition" class="text-right py-8"> |
Contributor
There was a problem hiding this comment.
I think we might be able to clean this up by using the same method we do for pacbioRunShow https://github.com/sanger/traction-ui/blob/develop/src/views/pacbio/PacbioRunShow.vue#L22. Where we have runTypes e.g. newRun. Maybe one for a future refactor.
| const create = () => { | ||
| busy.value = true | ||
| multiPoolCreateStore.createMultiPool().then(({ success, barcode, errors }) => { | ||
| multiPoolCreateStore.createMultiPool().then(({ success, id, errors }) => { |
Contributor
There was a problem hiding this comment.
Thinking about UX. I think on successful creation they are going to want to see each barcode of the sub pools created so they know what barcodes to print and which pools are where. Maybe on successful creation we should redirect to the persisted multi pool page for the new id?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2505
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version