Skip to content

[release] Merge Develop into Master for 14.60.0#4786

Merged
StephenHulme merged 184 commits intomasterfrom
develop
Apr 8, 2025
Merged

[release] Merge Develop into Master for 14.60.0#4786
StephenHulme merged 184 commits intomasterfrom
develop

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Mar 27, 2025

Proposed Changes

Instructions for Reviewers

  • Check stories are ready for release.
  • Check for any database migrations.
  • Check for debug code.
  • Check version is appropriate.

Everything above the horizontal rule will be overwritten on the next push
This PR was auto-generated on 2025-04-08T11:46:30+01:00


Additional Context

None

…rameters and ensure proper handling of aliquots
@BenTopping
Copy link
Contributor

@StephenHulme
One of the commits here #4794 contains the text 'closes # 701'. I think this is why the bunny update in the proposed changes is referencing an old and unrelated pull request. Maybe a small bug / edge case with the auto PR's proposed changes logic .

@github-actions github-actions bot changed the title [release] Merge Develop into Master for 14.59.0 [release] Merge Develop into Master for 14.59.1 Apr 7, 2025
@StephenHulme StephenHulme marked this pull request as ready for review April 7, 2025 11:28
@BenTopping BenTopping reopened this Apr 7, 2025
[ruby] Update pry-byebug 3.10.1 → 3.11.0 (minor)
@StephenHulme
Copy link
Contributor

@StephenHulme One of the commits here #4794 contains the text 'closes # 701'. I think this is why the bunny update in the proposed changes is referencing an old and unrelated pull request. Maybe a small bug / edge case with the auto PR's proposed changes logic .

Fixed now - well spotted and thanks for diagnosing 👌

@github-actions github-actions bot changed the title [release] Merge Develop into Master for 14.59.1 [release] Merge Develop into Master for 14.60.0 Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 41.01124% with 105 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@b8c3cdb). Learn more about missing BASE report.
Report is 206 commits behind head on master.

Files with missing lines Patch % Lines
app/controllers/plates_from_tubes_controller.rb 27.65% 68 Missing ⚠️
app/models/plate/creator.rb 21.21% 26 Missing ⚠️
app/models/lib_pool_norm_tube_generator.rb 0.00% 2 Missing ⚠️
lib/label_printer/pmb_client.rb 0.00% 2 Missing ⚠️
app/api/core/io/json/grammar.rb 0.00% 1 Missing ⚠️
app/controllers/admin/studies_controller.rb 0.00% 1 Missing ⚠️
app/helpers/assets_helper.rb 0.00% 1 Missing ⚠️
app/helpers/plates_helper.rb 50.00% 1 Missing ⚠️
app/models/flexible_submission.rb 0.00% 1 Missing ⚠️
app/models/linear_submission.rb 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4786   +/-   ##
=========================================
  Coverage          ?   86.54%           
=========================================
  Files             ?     1408           
  Lines             ?    30432           
  Branches          ?        0           
=========================================
  Hits              ?    26338           
  Misses            ?     4094           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme merged commit 7f66dac into master Apr 8, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants