Pip prototype #392
Merged
Pip prototype #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exodus.py only needed the version from the exodusII.h file. This removes the dependency on the location to make a pip workflow easier due to the lack of knowledge of where header files go by setuptools. It now places the version into exodus.py at CMake configuration time with a regex and parses that string in Python. Add tests for the new method of obtaining the version.
libexodus.so. Change the exodusII.h find method in cmake to be usable without installing first.
Due to the exodus3.in.py needing cmake variable replacement and to be moved before the setup.py is run, it is needed to call the configure before the instanciation of setup. However, because the congfigure needs variables to be set during build time it needs to be called again to make sure the libraries are placed in the correct place for pick up by the package.py
The setup.py now generates a relocatable binary wheel using auditwheel and patchelf. They are currently installing from PyPI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.