Link Build Test of 6843/merge by @orangewolf #311
16 fail in 0s
Annotations
Check warning on line 0 in app.controllers.concerns.hyrax.works_controller_behavior
github-actions / Test Results
Rails/Present (app.controllers.concerns.hyrax.works_controller_behavior) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Rails/Present: Use `if contexts.present?` instead of `unless contexts.blank?`.
/home/runner/work/hyrax/hyrax/app/controllers/concerns/hyrax/works_controller_behavior.rb:183:44
Check warning on line 0 in app.forms.hyrax.forms.resource_form
github-actions / Test Results
Layout/SpaceInsideBlockBraces (app.forms.hyrax.forms.resource_form) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:79:65
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:79:146
Check warning on line 0 in app.forms.hyrax.forms.resource_form
github-actions / Test Results
Metrics/CyclomaticComplexity (app.forms.hyrax.forms.resource_form) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Metrics/CyclomaticComplexity: Cyclomatic complexity for initialize is too high. [11/10]
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:55:7
Check warning on line 0 in app.forms.hyrax.forms.resource_form
github-actions / Test Results
Metrics/AbcSize (app.forms.hyrax.forms.resource_form) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Metrics/AbcSize: Assignment Branch Condition size for initialize is too high. [<11, 46, 12> 48.8/32]
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:55:7
Check warning on line 0 in app.forms.hyrax.forms.resource_form
github-actions / Test Results
Metrics/PerceivedComplexity (app.forms.hyrax.forms.resource_form) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Metrics/PerceivedComplexity: Perceived complexity for initialize is too high. [13/11]
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:55:7
Check warning on line 0 in app.forms.hyrax.forms.resource_form
github-actions / Test Results
Style/RedundantSelf (app.forms.hyrax.forms.resource_form) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Style/RedundantSelf: Redundant `self` detected.
Style/RedundantSelf: Redundant `self` detected.
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:79:25
/home/runner/work/hyrax/hyrax/app/forms/hyrax/forms/resource_form.rb:81:15
Check warning on line 0 in app.models.hyrax.file_set
github-actions / Test Results
Style/CommentAnnotation (app.models.hyrax.file_set) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Style/CommentAnnotation: Annotation keywords like `TODO` should be all upper case, followed by a colon, and a space, then a note describing the problem.
/home/runner/work/hyrax/hyrax/app/models/hyrax/file_set.rb:54:7
Check warning on line 0 in app.models.hyrax.flexible_schema
github-actions / Test Results
Lint/UselessAssignment (app.models.hyrax.flexible_schema) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Lint/UselessAssignment: Useless assignment to variable - `e`.
/home/runner/work/hyrax/hyrax/app/models/hyrax/flexible_schema.rb:33:27
Check warning on line 0 in app.models.hyrax.flexible_schema
github-actions / Test Results
Style/RedundantSelf (app.models.hyrax.flexible_schema) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Style/RedundantSelf: Redundant `self` detected.
/home/runner/work/hyrax/hyrax/app/models/hyrax/flexible_schema.rb:32:5
Check warning on line 0 in app.models.hyrax.resource
github-actions / Test Results
Metrics/ClassLength (app.models.hyrax.resource) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Metrics/ClassLength: Class has too many lines. [101/100]
/home/runner/work/hyrax/hyrax/app/models/hyrax/resource.rb:33:3
Check warning on line 0 in app.presenters.hyrax.work_show_presenter
github-actions / Test Results
Layout/TrailingWhitespace (app.presenters.hyrax.work_show_presenter) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Layout/TrailingWhitespace: Trailing whitespace detected.
/home/runner/work/hyrax/hyrax/app/presenters/hyrax/work_show_presenter.rb:60:1
Check warning on line 0 in app.presenters.hyrax.work_show_presenter
github-actions / Test Results
Metrics/MethodLength (app.presenters.hyrax.work_show_presenter) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Metrics/MethodLength: Method has too many lines. [20/14]
/home/runner/work/hyrax/hyrax/app/presenters/hyrax/work_show_presenter.rb:31:5
Check warning on line 0 in app.presenters.hyrax.work_show_presenter
github-actions / Test Results
Style/Next (app.presenters.hyrax.work_show_presenter) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Style/Next: Use `next` to skip iteration.
/home/runner/work/hyrax/hyrax/app/presenters/hyrax/work_show_presenter.rb:42:9
Check warning on line 0 in app.presenters.hyrax.work_show_presenter
github-actions / Test Results
Rails/Present (app.presenters.hyrax.work_show_presenter) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Rails/Present: Use `if value.present?` instead of `unless value.blank?`.
/home/runner/work/hyrax/hyrax/app/presenters/hyrax/work_show_presenter.rb:47:28
Check warning on line 0 in app.services.hyrax.simple_schema_loader
github-actions / Test Results
Lint/UnusedMethodArgument (app.services.hyrax.simple_schema_loader) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Lint/UnusedMethodArgument: Unused method argument - `version`.
Lint/UnusedMethodArgument: Unused method argument - `contexts`.
/home/runner/work/hyrax/hyrax/app/services/hyrax/simple_schema_loader.rb:11:39
/home/runner/work/hyrax/hyrax/app/services/hyrax/simple_schema_loader.rb:11:51
Check warning on line 0 in lib.hyrax.indexer
github-actions / Test Results
Metrics/MethodLength (lib.hyrax.indexer) failed
artifacts/rubocop-reports/rubocop.xml
Raw output
Metrics/MethodLength: Method has too many lines. [15/14]
/home/runner/work/hyrax/hyrax/lib/hyrax/indexer.rb:33:5
Check notice on line 0 in .github
github-actions / Test Results
16 tests found
There are 16 tests, see "Raw output" for the full list of tests.
Raw output
app.controllers.concerns.hyrax.works_controller_behavior ‑ Rails/Present
app.forms.hyrax.forms.resource_form ‑ Layout/SpaceInsideBlockBraces
app.forms.hyrax.forms.resource_form ‑ Metrics/AbcSize
app.forms.hyrax.forms.resource_form ‑ Metrics/CyclomaticComplexity
app.forms.hyrax.forms.resource_form ‑ Metrics/PerceivedComplexity
app.forms.hyrax.forms.resource_form ‑ Style/RedundantSelf
app.models.hyrax.file_set ‑ Style/CommentAnnotation
app.models.hyrax.flexible_schema ‑ Lint/UselessAssignment
app.models.hyrax.flexible_schema ‑ Style/RedundantSelf
app.models.hyrax.resource ‑ Metrics/ClassLength
app.presenters.hyrax.work_show_presenter ‑ Layout/TrailingWhitespace
app.presenters.hyrax.work_show_presenter ‑ Metrics/MethodLength
app.presenters.hyrax.work_show_presenter ‑ Rails/Present
app.presenters.hyrax.work_show_presenter ‑ Style/Next
app.services.hyrax.simple_schema_loader ‑ Lint/UnusedMethodArgument
lib.hyrax.indexer ‑ Metrics/MethodLength