Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination collection (issue #6684) #6985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zizneroz
Copy link

Fixes

Fixes #6684; refs #6684

Summary

Resolve issue #6684: Adjust collection page layout by changing the CSS display property to use flexbox for proper alignment of elements.


Guidance for testing

  • Navigate to the collections page in the application.
  • Verify that the layout of the collections now aligns correctly.
  • Test on various screen sizes and browsers to ensure the layout is responsive and consistent.
  • Check for any regressions in other areas where the same styles might be applied.

Type of change (for release notes)

notes-bugfix


Detailed Description

This pull request resolves #6684, where the collections page layout was misaligned due to the use of display: block. By updating the CSS property to display: flex in app/assets/stylesheets/hyrax/_collections.scss (line 687), the layout now uses flexbox for proper alignment and spacing.

Code changed:

// Before:
display: block;

// After:
display: flex;


@samvera/hyrax-code-reviewers

Copy link

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 22s ⏱️ - 2m 27s
 6 740 tests ±0   6 441 ✅ ±0  299 💤 ±0  0 ❌ ±0 
13 253 runs  ±0  12 848 ✅ ±0  405 💤 ±0  0 ❌ ±0 

Results for commit bb6ab8e. ± Comparison against base commit dd6f355.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc97abf8fd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff3f514ba40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc97a2a8208>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff3f5141b80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 72b2c66c-35e8-458a-b051-427f6d66913d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 07a9c5b3-6dd2-4dad-8561-34fccf70c597
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 584e7bc9-a42f-47b1-aa82-3897e8c0fe0f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 116f97ac-1652-45dc-8951-5f04cbefd06c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: dab78b5e-563f-417d-b2cb-413bc06336cc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 81bd9a07-ccbf-4ad8-85b7-e10db1a3980a
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1151623860>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3b82cb5150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f11516aa3d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3b8254fc80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5dc3763a-0001-477a-ab32-e69970aff589
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: e20ae0f5-14a1-4ab6-9dd4-a4315db0e44a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: d052a63a-c6fe-4a9b-9bca-231566637075
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 6fc8c512-4a18-4733-9302-9069d9a017c8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 6da14f12-fc9d-47ae-852a-480434ce640d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 396d9d99-40f0-46c3-8961-c2435c95123b
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination on collection view not displayed correctly
1 participant