Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column header #6981

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add column header #6981

merged 1 commit into from
Dec 10, 2024

Conversation

jlhardes
Copy link
Contributor

@jlhardes jlhardes commented Dec 9, 2024

Fixes

Fixes #6792

Summary

Add column header for table accessibility

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • View Settings > Features page from Dashboard
  • Use SiteImprove browser plugin to check page

Type of change (for release notes)

  • notes-minor New Features that are backward compatible

Detailed Description

Added static header value "Status" for enabled/disabled badge column on Features page. There doesn't seem to be an equivalent variable or value to call up like there is for the Feature, Description, and Action column headers but the value works to add the column header for accessibility purposes.

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Dec 9, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 19m 0s ⏱️ + 2m 29s
 6 733 tests ±0   6 437 ✅ ±0  296 💤 ±0  0 ❌ ±0 
13 240 runs  ±0  12 841 ✅ ±0  399 💤 ±0  0 ❌ ±0 

Results for commit 344b770. ± Comparison against base commit abd5955.

This pull request removes 275 and adds 275 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f407a6c2f98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007feffe221410>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f407a631548>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007feffd2bfa08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: de734d03-6e8f-4678-a8ef-c23fec5bcca2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d2cb4476-ff08-4ad4-bb60-56a96e85289e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 88ac13a0-43fd-49fd-989b-ba2da02a477a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 7eb7c9a7-7ff5-438e-9080-d814a85b4d2c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: f4cd4d33-8f3a-4357-9ba7-9829729feaae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5e98a598-2ecb-49e3-b766-39197563c7cc
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0bee6a2d08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd4da445a00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0bee8e9120>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd4da32e108>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 389659c7-d190-49b3-bde3-50b00b587857
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: ed51cb65-aa2b-4c19-b3fe-c436005cd081
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 95a6672e-76fc-4aea-ae86-c24ab812bdfe
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 8ceb8536-551f-44e5-86dc-ba823d02f6b9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 263540bf-6400-4a29-8cfc-2c2de306557e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 4cee105d-1fa5-4b5c-8b37-b1b40ef33801
…

@randalldfloyd randalldfloyd merged commit 54e28d2 into main Dec 10, 2024
22 checks passed
@randalldfloyd randalldfloyd deleted the issue-6792 branch December 10, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tags on Features page are missing context
2 participants