Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported aria attributes in dashboard #6980

Merged

Conversation

rodyoukai
Copy link
Contributor

@rodyoukai rodyoukai commented Dec 7, 2024

Fix #6840

The aria-expanded attribute no longer appears on the UL tag.

Copy link

github-actions bot commented Dec 7, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 20m 2s ⏱️ +24s
 6 740 tests ±0   6 441 ✅ ±0  299 💤 ±0  0 ❌ ±0 
13 253 runs  ±0  12 848 ✅ ±0  405 💤 ±0  0 ❌ ±0 

Results for commit 127514f. ± Comparison against base commit 1a642ac.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f11bb4b5158>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5dee641f60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1197084ee0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5df0156558>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 1b797e04-4edd-408d-988b-4c725bcf50b6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: daa8f2a0-5c32-4da0-959a-459d3de95a7e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: aac1021e-2a23-4bd0-9e23-55c87aad21c7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 534800b1-816a-404d-a222-d2a4d8715828
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: e4cdc3c7-6156-4e59-be5b-cfdc2cc95fe5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 28120938-f5d1-4b90-9068-9b334aa02a81
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f35b9796058>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fac2cc2bb88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f35b977bcd0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fac2cdd7f90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 085fafd5-99b2-41d4-971f-1818b020153d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 78628e5d-5766-4f18-921b-37f177f0f5cd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 7bc6c900-f63e-4540-a2b1-63171ba942b4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: c00dad2b-e07c-48be-8be5-1da99dd21389
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 7ee80234-7ac9-462e-a415-e11cccff304e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 0c27214e-c5a8-4072-8730-d8083e52b99e
…

♻️ This comment has been updated with latest results.

@rodyoukai rodyoukai requested a review from rjkati December 8, 2024 14:23
@rodyoukai rodyoukai force-pushed the Fix-unsupported-ARIA-attributes-in-dashboard branch 2 times, most recently from 997ee2d to f441894 Compare December 10, 2024 00:38
Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@dlpierce dlpierce merged commit dd6f355 into samvera:main Dec 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsupported ARIA attributes in expanded Your Activity and Settings menus
2 participants