Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6783 #6964

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Issue 6783 #6964

merged 2 commits into from
Nov 8, 2024

Conversation

jlhardes
Copy link
Contributor

@jlhardes jlhardes commented Nov 7, 2024

Fixes

Fixes #6783

Summary

Adds labels and aria-labelledby attribute to checkbox lists on Expired Active Embargoes

Type of change (for release notes)

  • notes-minor New Features that are backward compatible

Detailed Description

Adds label around titles in checkbox list (or around question text or "Select All" text) and adds aria-labelledby attribute on checkbox inputs using checkbox input id. The batch_select/_add_button seems to be a reusable bit of code but from what I can tell the change there should work in other checkbox lists that might use it.

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Nov 7, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 20m 30s ⏱️ + 3m 52s
 6 729 tests +1   6 432 ✅ +1  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 9e76ac2. ± Comparison against base commit 83413b6.

This pull request removes 273 and adds 274 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7722f212c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcf08726698>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7722f26f48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fcf0a719ec8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 058378f3-5bb8-48f4-9196-8db2b80f8090
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2402ae0e-2d3b-46a4-9965-b3376bf90eeb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a5550cc8-c904-4559-a9eb-7f1c1d634077
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 1d3e9e45-7d81-4b06-81b5-1b206e11f71f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 7ee4ec34-1d62-4fb9-bd84-b2746c7bf553
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: a6f11e80-2499-4965-985a-aa952472a680
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3b2ee20de0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f420aef6408>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3b2ee2eee0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4212f04118>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: b07b2622-48d3-4114-afe5-246b3c0819e3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 154ac18b-c233-49d4-8260-f0a6e41824fe
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 39d1ab64-1865-42c6-b759-d21f0677a0d6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: e7e91211-221e-4926-88e8-9851f2375359
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 2552a9dc-27b5-41c2-bd8d-ca7a64c62e78
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 0bbaa40b-8138-4a28-91e0-ffa0321fac93
…

♻️ This comment has been updated with latest results.

@dlpierce dlpierce merged commit c621d57 into main Nov 8, 2024
23 checks passed
@dlpierce dlpierce deleted the issue-6783 branch November 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing labels for checkboxes on Manage Embargoes page
2 participants