Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes accessibility issues with the member image partials in the File Manager #6962

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

randalldfloyd
Copy link
Contributor

@randalldfloyd randalldfloyd commented Nov 5, 2024

Fixes

Fixes #6812
Fixes #6813

Summary

Adds minor accessibility fixes to the partials that render the member image panels. It makes sure the thumbnails have text alternatives, and the edit title fields have labels.

  • notes-minor

Copy link

github-actions bot commented Nov 5, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 53s ⏱️ + 2m 0s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit bdf986e. ± Comparison against base commit c56c4a8.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8c5c9c2580>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fccd08321c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8c66262a88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fccd0c962c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ac5954f2-73c7-43ba-a7cb-ba258dd9ce2f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 3f8590fe-defd-45ab-8503-3fb4d9cd2a58
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b9ff3af0-856f-46b3-b0f2-fcd06ed9672f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 1695e35c-ea8e-4f96-bc21-8295acf9cd3d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 1e355e41-0aa0-4fb1-95e6-b31618146bff
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 01455be7-5abb-47b6-ada6-0820e00027b0
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9b1e32f788>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb06b9d7948>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9b1e3262c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb06b968340>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: eba172e8-1ffe-44da-90b7-6ff8962f27ba
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 00564882-38f7-4dd8-8128-f50c5da51c09
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 772552b1-21cb-4631-b65a-b20ec1b8e761
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 42d70dab-e830-441e-8f30-301b05cadc33
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: fa6ee8f4-cf80-4bea-85ab-997714742c20
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 459a352a-9a67-48c5-b77f-34b7b69ea68a
…

♻️ This comment has been updated with latest results.

@dlpierce dlpierce merged commit 83413b6 into main Nov 6, 2024
22 checks passed
@dlpierce dlpierce deleted the issues-6812_6813 branch November 6, 2024 22:00
@dlpierce dlpierce added the notes-accessibility Release Notes: Accessibility label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-accessibility Release Notes: Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file manager form fields missing labels file manager image thumbnails don't have text alternatives
2 participants