Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated user activity log table #6960

Conversation

rkuehn-uofl
Copy link
Contributor

Fixes

Fixes #6353

Summary

Updated user activity log table to include "No user activity" note when user activity is missing

Type of change (for release notes)

  • notes-minor Accessibility: Added text to indicate when no user activity is present

@samvera/hyrax-code-reviewers

@rkuehn-uofl rkuehn-uofl linked an issue Nov 4, 2024 that may be closed by this pull request
3 tasks
Copy link

github-actions bot commented Nov 4, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 15m 9s ⏱️ -10s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit d1a39f7. ± Comparison against base commit bb28056.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f398d3f6060>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f822d7961a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f398d3fe120>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f823dd3cd10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 04176dec-4896-4e37-8363-914f2710d068
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0971ea44-6d9f-4c44-abbd-19b4db2830b9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c190864f-4427-4485-bec3-05fd2f116b37
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 97d392ed-1c3a-4d05-88fb-9993cf9b5713
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 05ebbd5a-ac74-4a20-8e70-5fd3f4366f68
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 6e11a7b1-ced4-4003-9f6a-46918d6395af
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8567369ec8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc546b8d220>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8567ab4390>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc546b857a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: f5b38557-6efc-4ecb-b91f-f8d49bef8389
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0ff84a58-663d-48c3-9add-08fc6c0b22fc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 5d525687-355a-4413-88e5-a5a56591ec75
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: d4c09d4f-242e-4690-aaa1-74fc57e6043c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: db163da9-68b7-4a28-99d9-b391c651deb2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 4c382698-5e42-41b2-ae94-5e170d57e0ca
…

@randalldfloyd randalldfloyd merged commit c56c4a8 into main Nov 5, 2024
22 checks passed
@randalldfloyd randalldfloyd deleted the 6353-file-details---user-activity-table-has-accessibility-issue-when-empty branch November 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Details - User Activity table has accessibility issue when empty
2 participants