h1 hidden but make contrasty anyway #6958
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6892
Summary
Second try: fixing h1 elt that is sr-only but still being flagged for contrast.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
*Running wave on the dashboard should not flag the navbar for contrast.
*
*
Type of change (for release notes)
notes-minor
Detailed Description
In the dashboard masthead, the visible span is compliant regarding contrast; the hidden h1 elt is not. Proposed solution is to add navbar-text class to the h1; .navbar-text is defined in views/shared/_appeearance_styles.html.erb and appears to just set color to appearance.header_text_color (.navbar-brand is set to the same color, and is used on the masthead/logo).
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers