move span inside button

[lsat12357]

Fixes

Fixes #6811

Summary

In the fileset edit, permissions tab, button to add groups to permitted list were without text

Guidance for testing, such as acceptance criteria or new user interface behaviors:

• Siteimprove checking a fileset edit page with the permissions tab showing should not return "Button missing a text alternative" error.

Type of change (for release notes)

notes-minor

Detailed Description

In views/hyrax/file_sets/_permission_form.html.erb, only the second "add" button was getting flagged; this seems to be because the span with help text is within the button tag for the add user, but outside the button tag for add group. Moving the span cleared the error.
(First solution, adding aria-label was the wrong move.)

Changes proposed in this pull request:

*Modifies html in views/hyrax/file_sets/_permission_form.html.erb
*
*

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    17 files  ±0      17 suites  ±0   2h 18m 38s ⏱️ -55s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit b6e1660. ± Comparison against base commit 71d7a79.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2e02d98d48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa017bd9c50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2e02d04760>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa00737d350>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5186aae9-3b2e-421b-818a-da4ae996c32c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 35f14477-2fef-431d-a94a-1bb5d96d8398
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: d949b9a1-6f5e-4e80-8264-9c9bd8311da7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 1bbcce7a-53f3-40e7-90f6-0fe8b09c2b2c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 2b84d21e-6296-4c9e-b12b-305047a2c562
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 75708187-fa28-4457-82e8-7e701ef6103e
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff300bff018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff5e601d720>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff300bf4d98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff5e5290288>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 3065d8c7-a34f-46b8-887a-0bf0a134f667
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 47a2239d-accb-4aa9-9e17-60ab539f83e9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 27afe492-a7c7-4bce-a91e-2a10754c00dd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: a75df4cf-a595-4296-89e0-c9dea6afa77f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: c2fb33e8-a266-4a1c-9bd4-aef7885222c9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 6a470da5-f1e7-481a-abce-cc2ce20a9295
…

♻️ This comment has been updated with latest results.