Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support Ruby 3.3 and Rails 7.2 #6913

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Conversation

randalldfloyd
Copy link
Contributor

First try at building/testing Ruby 3.3 and Rails 7.2

Copy link

github-actions bot commented Oct 2, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 15m 56s ⏱️ - 2m 53s
 6 740 tests ±0   6 435 ✅  - 6  299 💤 ±0  6 ❌ +6 
13 256 runs  +3  12 842 ✅  - 6  405 💤 ±0  9 ❌ +9 

For more details on these failures, see this check.

Results for commit cf2f47b. ± Comparison against base commit dd6f355.

This pull request removes 275 and adds 275 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc97abf8fd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff3f514ba40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc97a2a8208>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff3f5141b80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 72b2c66c-35e8-458a-b051-427f6d66913d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 07a9c5b3-6dd2-4dad-8561-34fccf70c597
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 584e7bc9-a42f-47b1-aa82-3897e8c0fe0f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 116f97ac-1652-45dc-8951-5f04cbefd06c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: dab78b5e-563f-417d-b2cb-413bc06336cc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 81bd9a07-ccbf-4ad8-85b7-e10db1a3980a
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5cbf9ba140>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd1493ae608>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5c9ece7e60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd14afca788>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 21dd9731-b43d-4eed-b7f5-e380347ae112
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8ac29fcd-d339-430f-a372-a7d2149f6d26
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a9e5c9b2-86af-4f9b-b80b-6513b78d5f05
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: eaa46f03-7290-455c-afc3-77afdbb44621
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 544c8532-68fc-43c6-9ad0-73f6c2ab7bc7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: c6a87eba-99a1-4e08-ae88-fafdc198dc47
…

♻️ This comment has been updated with latest results.

@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from d2d1d8e to c54a552 Compare October 2, 2024 22:27
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 12 times, most recently from 9683dc6 to ad0ba7f Compare October 11, 2024 20:00
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from e95df99 to e6bf157 Compare October 15, 2024 20:17
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 3 times, most recently from fd990ce to 64658a6 Compare December 5, 2024 19:40
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 3 times, most recently from 2c00530 to f8aac41 Compare December 9, 2024 20:05
@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from eb34603 to ef66ca8 Compare December 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants