-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing review #6845
Merged
Merged
Testing review #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files + 1 17 suites +1 2h 15m 42s ⏱️ + 10m 4s Results for commit 28c923e. ± Comparison against base commit 4b74958. This pull request removes 264 and adds 403 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
rkuehn-uofl
force-pushed
the
testing-review
branch
from
July 16, 2024 15:30
4ec5086
to
e07c5de
Compare
Update to correct text color contrast does not meet minimum requirements on edit file page #6810
rkuehn-uofl
force-pushed
the
testing-review
branch
from
July 16, 2024 15:49
e07c5de
to
991acc7
Compare
Updates tags to include accessibility
dlpierce
added
notes-accessibility
Release Notes: Accessibility
and removed
accessibility-concern
labels
Aug 6, 2024
dlpierce
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6810
Summary
On dev.nurax.samvera.org (Hyrax 5.0.1), the Who should be able to view or download this content? text on the Permissions tab of the Edit File page does not meet minimum WCAG AA color contrast requirements
Guidance for testing, such as acceptance criteria or new user interface behaviors:
*In Chrome, download the Site Improve browser extension
As an admin, go to https://dev.nurax.samvera.org/concern/file_sets/p2676v71k/edit?locale=en#permissions_display and run the Site Improve browser extension
edit_file_color_contrast
Type of change (for release notes)
notes-accessibility-concern
Detailed Description
Location: /hyrax/app/assets/stylesheets/hyrax/_forms.scss
The color was changed from #99999 to #4f4f4f on line #3 within legend-small CSS tag and tested to meet 7:
For Review
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers