Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing review #6845

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Testing review #6845

merged 3 commits into from
Aug 7, 2024

Conversation

rkuehn-uofl
Copy link
Contributor

Fixes

Fixes #6810

Summary

On dev.nurax.samvera.org (Hyrax 5.0.1), the Who should be able to view or download this content? text on the Permissions tab of the Edit File page does not meet minimum WCAG AA color contrast requirements

Guidance for testing, such as acceptance criteria or new user interface behaviors:

*In Chrome, download the Site Improve browser extension
As an admin, go to https://dev.nurax.samvera.org/concern/file_sets/p2676v71k/edit?locale=en#permissions_display and run the Site Improve browser extension
edit_file_color_contrast

Type of change (for release notes)

notes-accessibility-concern

Detailed Description

Location: /hyrax/app/assets/stylesheets/hyrax/_forms.scss
The color was changed from #99999 to #4f4f4f on line #3 within legend-small CSS tag and tested to meet 7:

legend small {
  margin-left: 0.5em;
  color: #4f4f4f;
  font-size: 15px;
}

For Review

Changes proposed in this pull request:

  • Change "color: #99999" to "color: #4f4f4f" within legend-small CSS block to meet 2.85:1 ratio accessibility standard

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Jul 9, 2024

Test Results

    17 files  +  1      17 suites  +1   2h 15m 42s ⏱️ + 10m 4s
 6 705 tests +139   6 408 ✅ +141  297 💤  - 1  0 ❌  - 1 
13 178 runs  +979  12 783 ✅ +972  395 💤 +8  0 ❌  - 1 

Results for commit 28c923e. ± Comparison against base commit 4b74958.

This pull request removes 264 and adds 403 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1740e23ac0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f727a70c300>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1740e2c800>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f727fa45c88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 4be5877a-4614-4181-b9c1-8e456d6466d6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 87b5a23b-f0e4-4c3d-8f71-ac8a60add89d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 3458d59b-b8a7-49bf-8062-b6e4066dac67
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 051a8d99-ce8a-4d79-af28-6386cd98f239
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: cf1fc3df-a2a3-4259-945d-d73a34fb51b5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: d4783baa-1c4b-496c-8732-34a7f0fa6335
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa513aeb040>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007facc77558c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa510fede88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007facbff848a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 7bf34549-b830-4b58-be8f-062abd78555d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: fa7d91b8-5319-4768-8907-5c867e17d95c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 5ccc621e-f573-42af-bf6f-41c8491fb67f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ad7d587a-139f-4644-836b-f1e4799f1c14
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: c23667a6-d940-4f06-a638-b6a3ec3c509d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: c1372ad2-3b78-4b52-8893-1fefa700b7ee
…

♻️ This comment has been updated with latest results.

Update to correct text color contrast does not meet minimum requirements on edit file page #6810
@rkuehn-uofl rkuehn-uofl requested a review from dlpierce August 6, 2024 17:17
@dlpierce dlpierce added notes-accessibility Release Notes: Accessibility and removed accessibility-concern labels Aug 6, 2024
@rkuehn-uofl rkuehn-uofl marked this pull request as ready for review August 7, 2024 17:09
@dlpierce dlpierce merged commit 10d458a into main Aug 7, 2024
22 checks passed
@dlpierce dlpierce deleted the testing-review branch August 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-accessibility Release Notes: Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text color contrast does not meet minimum requirements on edit file page
2 participants