Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix for configurable model registration #6738

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShanaLMoore
Copy link
Contributor

Because the model registry for Collection and Administrative Sets weren't using the Hyrax configuration, incorrect mappings were observed which prevented the collection edit page from loading. In this commit we resolve this issue by using the Hyrax configuration in the model registry.

BEFORE:

Screenshot 2024-03-08 at 09-58-18 Action Controller Exception caught

AFTER:

image

Because the model registry for Collection and Administrative Sets weren't using the Hyrax configuration, incorrect mappings were observed which prevented the collection edit page from loading. In this commit we resolve this issue by using the Hyrax configuration in the model registry.
@ShanaLMoore ShanaLMoore added the notes-bugfix Release Notes: Fixed a bug label Mar 8, 2024
Copy link

github-actions bot commented Jun 7, 2024

Test Results

    1 files   -     8      1 suites   - 8   0s ⏱️ - 16m 41s
    1 tests  - 4 758      0 ✅  - 4 696  0 💤  - 63  1 ❌ +1 
1 707 runs   - 4 784  1 706 ✅  - 4 722  0 💤  - 63  1 ❌ +1 

For more details on these failures, see this check.

Results for commit b1cbd69. ± Comparison against base commit 4d2c654.

This pull request removes 4759 and adds 1 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3499610150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f349045ec48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9591d9c7-9508-4ffd-b2be-f57a55ae9895
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: efbb557d-140f-4a84-bab1-216093f8aca0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 476c198b-b1ef-41f1-b058-74449b22d305
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin #admin? is true
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create #<Hyrax::PermissionTemplate:0x00007f349961b2d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f34904c67d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: 38c0fa8d-3525-43af-bd71-457c16642117
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: 691e909d-0a0a-448e-82fe-24e1b880f739
…
lib.wings.setup ‑ Layout/ExtraSpacing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants