☑️ Demonstrate error for #6702 #6703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
i6702-demonstrating-error
branch
from
48cbb54 to
59db40d
Compare
jeremyf
added a commit
to scientist-softserv/valkyrie
that referenced
this pull request
Feb 19, 2024
This test is fragile in that it does not account for the fact that we can specify a :prepopulate option for a property. When you specify the `:prepopulate` option (as in `Hyrax::Form::PcdmCollection`) and use this shared spec, then the now deleted spec fails with no recourse. Related to: - samvera/hyrax#6702 - samvera/hyrax#6703
|
We'll need an updated version of Valkyrie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.