Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing AdminSet manager does not update edit_access in solr doc #570

Closed
elrayle opened this issue Mar 16, 2017 · 3 comments
Closed

Removing AdminSet manager does not update edit_access in solr doc #570

elrayle opened this issue Mar 16, 2017 · 3 comments
Assignees
Labels
bug Collection impacts the Collection part of PCDM Model
Milestone

Comments

@elrayle
Copy link
Contributor

elrayle commented Mar 16, 2017

Descriptive summary

When a user is removed as manger of an AdminSet via the UI, the user is not removed from the edit_access_person_ssim in the solr doc. (Likely the same is true for group managers.)

Expected behavior

When a manager is removed, the edit_access_person/group_ssim in the solr doc for the AdminSet should have the user's id removed.

Actual behavior

When a manager is removed, the edit_access_person_ssim is unchanged.

Steps to reproduce the behavior

Prerequisite:

  1. Create 1 admin user and 1 non-admin user
  2. Create an Admin Set
  3. Login as an admin user
  4. Create an Admin Set and Save
  5. Add non-admin user as a manager
  6. Click the Participants tab
  7. Add Participants -> Add user: -> set to non-admin user
  8. Set role to Manager
  9. Click Add button
  10. VERIFY: Check solr document for the new Admin Set in Solr and verify that the selected user is in the edit_access_person_ssim list.

Reproduce the issue

  1. Remove the user as manager
  2. From the Participants tab, click the Remove button next to the non-admin user just added
  3. NOTICE: Check solr document for the Admin Set in Solr and notice that the selected user is still in the edit_access_person_ssim list.

EXPECTED: I would expect the edit_access_person_ssim to no longer include the removed manager.

@elrayle elrayle added bug Collection impacts the Collection part of PCDM Model labels Mar 16, 2017
@mjgiarlo mjgiarlo added this to the 1.0.0 milestone Mar 16, 2017
@jcoyne
Copy link
Member

jcoyne commented Mar 16, 2017

@elrayle were you testing before or after this was merged? #567

@elrayle
Copy link
Contributor Author

elrayle commented Mar 17, 2017

I took the latest this morning. I still see the described behavior.

@jcoyne
Copy link
Member

jcoyne commented Mar 17, 2017

@elrayle thanks for checking. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Collection impacts the Collection part of PCDM Model
Projects
None yet
Development

No branches or pull requests

4 participants