Adding feature limit class attribute (#6680)

* Adding feature limit class attribute

* 🐛 Fix subject of spec

app/models/featured_work.rb

@@ -1,21 +1,29 @@
 # frozen_string_literal: true
 class FeaturedWork < ActiveRecord::Base
-  FEATURE_LIMIT = 5
+  ##
+  # @!group Class Attributes
+  #
+  # @!attribute feature_limit [r|w]
+  #   @return [Integer]
+  class_attribute :feature_limit, default: 5
+  # @!endgroup Class Attributes
+  ##
+
   validate :count_within_limit, on: :create
-  validates :order, inclusion: { in: proc { 0..FEATURE_LIMIT } }
+  validates :order, inclusion: { in: proc { 0..feature_limit } }
 
   default_scope { order(:order) }
 
   def count_within_limit
     return if FeaturedWork.can_create_another?
-    errors.add(:base, "Limited to #{FEATURE_LIMIT} featured works.")
+    errors.add(:base, "Limited to #{feature_limit} featured works.")
   end
 
   attr_accessor :presenter
 
   class << self
     def can_create_another?
-      FeaturedWork.count < FEATURE_LIMIT
+      FeaturedWork.count < feature_limit
     end
   end
 end

spec/models/featured_work_spec.rb

@@ -2,17 +2,23 @@
 RSpec.describe FeaturedWork, type: :model do
   let(:feature) { described_class.create(work_id: "99") }
 
+  describe '.feature_limit' do
+    subject { described_class.feature_limit }
+
+    it { is_expected.to be_a(Integer) }
+  end
+
   it "has a file" do
     expect(feature.work_id).to eq "99"
   end
 
   it "does not allow six features" do
-    5.times do |n|
+    described_class.feature_limit.times do |n|
       expect(described_class.create(work_id: n.to_s)).not_to be_new_record
     end
     described_class.create(work_id: "6").tap do |sixth|
       expect(sixth).to be_new_record
-      expect(sixth.errors.full_messages).to eq ["Limited to 5 featured works."]
+      expect(sixth.errors.full_messages).to eq ["Limited to #{described_class.feature_limit} featured works."]
     end
     expect(described_class.count).to eq 5
   end
@@ -29,7 +35,7 @@
     end
     context "when five exist" do
       before do
-        5.times do |n|
+        described_class.feature_limit.times do |n|
           described_class.create(work_id: n.to_s)
         end
       end