Test report remote file errors

.github/workflows/test.yml

@@ -21,7 +21,10 @@ jobs:
         uses: actions/[email protected]
         with:
           path: vendor/bundle
-          key: ${{ matrix.ruby }}
+          key: ${{ runner.os }}-bundle-${{ matrix.ruby }}-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-bundle-${{ matrix.ruby }}-
+            ${{ runner.os }}-bundle-
 
       - name: Setup Ruby
         uses: ruby/[email protected]

Gemfile

@@ -26,6 +26,7 @@ else
 end
 
 gem 'oai'
+gem 'pg'
 gem 'rsolr', '>= 1.0'
 gem 'rspec-rails'
 gem 'twitter-typeahead-rails', '0.11.1.pre.corejavascript'

app/factories/bulkrax/valkyrie_object_factory.rb

@@ -433,7 +433,6 @@ def uploaded_remote_files(remote_files: [])
       remote_files.map do |r|
         file_path = download_file(r["url"])
         next unless file_path
-
         create_uploaded_file(file_path, r["file_name"])
       end.compact
     end
@@ -449,8 +448,7 @@ def download_file(url)
         file.rewind
         file.path
       rescue => e
-        Rails.logger.debug "Failed to download file from #{url}: #{e.message}"
-        nil
+        raise "Failed to download file from #{url}: #{e.message}"
       end
     end
 
@@ -460,8 +458,7 @@ def create_uploaded_file(file_path, file_name)
       file.close
       uploaded_file
     rescue => e
-      Rails.logger.debug "Failed to create Hyrax::UploadedFile for #{file_name}: #{e.message}"
-      nil
+      raise "Failed to create Hyrax::UploadedFile for #{file_name}: #{e.message}"
     end
 
     # @Override Destroy existing files with Hyrax::Transactions