Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacored and backfilled tests, removed some lenses we weren't using #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bmaddy
Copy link
Contributor

@bmaddy bmaddy commented Apr 22, 2014

Fixes #1.

I removed some lenses. I don't believe you guys are using these anywhere, but I wanted to do a PR to make sure. I didn't see any of these in the ActiveFedora codebase anywhere. I'm not sure if any of these were evening working yet.

Removed:
hash_update
load_model
load_or_build_orm

@bmaddy
Copy link
Contributor Author

bmaddy commented Apr 24, 2014

Hmm, it looks like I can't merge anymore. @jcoyne, @cbeer, if you guys aren't using any of those three lenses I removed we should merge this to get the better test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test any untested lenses
2 participants