Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subject.agent to subject.user #1087

Merged
merged 2 commits into from
Nov 9, 2016
Merged

Change subject.agent to subject.user #1087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71ba31
Change subject.agent to subject.user
straleyb Nov 9, 2016
8bbbaa8
Re-adds in one 'subject.agent'
straleyb Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/curation_concerns/forms/workflow_action_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def save

def authorized_for_processing
return true if CurationConcerns::Workflow::PermissionQuery.authorized_for_processing?(
user: subject.agent,
user: subject.user,
entity: subject.entity,
action: sipity_workflow_action
)
Expand Down
2 changes: 1 addition & 1 deletion app/services/curation_concerns/workflow/workflow_action_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def update_sipity_workflow_state

def create_sipity_comment
return true unless comment_text.present?
Sipity::Comment.create!(entity: subject.entity, agent: subject.agent, comment: comment_text)
Sipity::Comment.create!(entity: subject.entity, agent: subject.user, comment: comment_text)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change caused the build to break

end

def handle_sipity_notifications(comment:)
Expand Down