-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notify dependency to 8.0.0, bumping MSRV to 1.77 #327
base: main
Are you sure you want to change the base?
Conversation
Thanks so much. I was 6 months ago, but see pydantic/pydantic-core#1315 - @tiran generally knows what he's talking about:
Since AFAIK there's no advantage to users of |
Advantages I see from 8:
|
Yes, this is a reasonable motivation for keeping a somewhat older MSRV if possible. The situation has changed a little, though: RHEL 9.5 and RHEL8.10 both shipped with Rust 1.79. I don’t know much about the UBI images, but since they’re Red Hat products, I assume they’ve been updated too. It’s possible, then, that MSRV 1.77 would now be fine for @tiran and those with similar needs. Full disclosure and context:
|
Thanks for pinging me. In general I aiming for a fair balance between upstream progress and downstream packaging. Downstream should not hold upstream back. As a downstream maintainer, I want upstream to innovate, improve, and evolve. I also appreciate it when upstream developers keep downstream into mind. @samuelcolvin's reaction is a great example. Thanks! If a newer Rust version helps the project, then please update. Downstream has means to work around the problem. In worst case, we package a slightly older versions until we can update. UBI are Red Hat's universal base images. Simply speaking they provide a public subset of RHEL including Rust. They always track the latest y-stream releases. The latest ubi9 images are based on RHEL 9.5 with Rust 1.79. |
This isn’t really urgent, but
notify
8.0.0 was just released (changelog), and it does look like the dependency inwatchfiles
could be updated without code changes. Everything still compiles, and the tests still pass. However, this does bring an MSRV increase from 1.63 to 1.77.