Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use notify 7.0.0 instead of a fork of 6.1.1 #322

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

musicinmybrain
Copy link
Contributor

As @decathorpe noticed, notify-rs/notify@146b1bd appears to be the same as notify-rs/notify@0f87ab1 in the notify fork.

Therefore, it should be possible to use the released version of notify 7.0.0.

I tried this and got one test failure,

=================================================================================================== FAILURES ===================================================================================================
_________________________________________________________________________________________ test_awatch_interrupt_raise __________________________________________________________________________________________

self = <tests.test_watch.MockRustNotifyRaise object at 0x7ff6cadfbb60>, args = (1600, 50, 5000, <threading.Event at 0x7ff6ca55c9b0: set>)

    def watch(self, *args):
        if self.i == 1:
>           raise KeyboardInterrupt('test error')
E           KeyboardInterrupt: test error

tests/test_watch.py:204: KeyboardInterrupt
[…]

but this already happens for me on the current main, so this isn’t a regression.

This PR would resolve #312.

@samuelcolvin samuelcolvin added the Full Build cause CI to do a full build label Jan 10, 2025
@samuelcolvin
Copy link
Owner

LGTM, thanks so much for spotting this.

I've just kicked off a full build, if that passes, happy to merge. Do you want a release with this in?

@musicinmybrain
Copy link
Contributor Author

I've just kicked off a full build, if that passes, happy to merge. Do you want a release with this in?

We’ve already applied this as a downstream patch in the Fedora package, so a release isn’t urgent for us.

On the other hand, it’s always nice to get rid of downstream patches, and a release might be helpful for other distribution packagers – @baldurmen?

@samuelcolvin samuelcolvin merged commit 65713ea into samuelcolvin:main Jan 10, 2025
46 checks passed
@samuelcolvin
Copy link
Owner

thanks so much, I'll do a release soon.

@musicinmybrain
Copy link
Contributor Author

Thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions on the use of a fork of notify
2 participants