E_NOTICE is now E_WARNING for undefined array key ref https://3v4l.or…

…g/okACat
samsonasik · Jun 25, 2021 · cad644e · cad644e
1 parent e908d68
commit cad644e
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -340,12 +340,12 @@ Give it a try!
 
 _**Web Access**_
 
-| URl                                   | Preview For     |
-|---------------------------------------|-----------------|
-| http://yourlaminasormezzioapp/error-preview        | Exception       |
-| http://yourlaminasormezzioapp/error-preview/error  | Error           |
-| http://yourlaminasormezzioapp/error-preview/notice | PHP E_NOTICE    |
-| http://yourlaminasormezzioapp/error-preview/fatal  | PHP Fatal Error |
+| URl                                                 | Preview For     |
+|-----------------------------------------------------|-----------------|
+| http://yourlaminasormezzioapp/error-preview         | Exception       |
+| http://yourlaminasormezzioapp/error-preview/error   | Error           |
+| http://yourlaminasormezzioapp/error-preview/warning | PHP E_WARNING   |
+| http://yourlaminasormezzioapp/error-preview/fatal   | PHP Fatal Error |
 
 You will get the following page if display_errors config is 0:
 

diff --git a/spec/Fixture/config/autoload-for-enable-display-errors/error-hero-module.local.php b/spec/Fixture/config/autoload-for-enable-display-errors/error-hero-module.local.php
@@ -60,7 +60,7 @@
             // excluded php errors
             'exclude-php-errors' => [
                 \E_USER_DEPRECATED,
-                \E_NOTICE,
+                \E_WARNING,
             ],
 
             // show or not error

diff --git a/spec/Fixture/config/autoload-for-specific-error-and-exception/error-hero-module.local.php b/spec/Fixture/config/autoload-for-specific-error-and-exception/error-hero-module.local.php
@@ -51,7 +51,7 @@
             'exclude-php-errors' => [
 
                 // can be specific error with specific message
-                [\E_NOTICE, 'Undefined offset: 1'],
+                [\E_WARNING, 'Undefined array key 1'],
 
             ],
 

diff --git a/spec/Handler/Writer/Checker/DbSpec.php b/spec/Handler/Writer/Checker/DbSpec.php
@@ -85,7 +85,7 @@
             allow($resultSet)->toReceive('current')->andReturn(null);
             allow(TableGateway::class)->toReceive('selectWith')->with($select)->andReturn($resultSet);
 
-            $actual = $this->writerHandler->isExists('file', 1, 'Undefined offset: 1', 'http://serverUrl/uri', 'E_NOTICE');
+            $actual = $this->writerHandler->isExists('file', 1, 'Undefined array key 1', 'http://serverUrl/uri', 'E_WARNING');
             expect($actual)->toBe(false);
 
         });
@@ -116,7 +116,7 @@
             );
             allow(TableGateway::class)->toReceive('selectWith')->with($select)->andReturn($resultSet);
 
-            $actual = $this->writerHandler->isExists('file', 1, 'Undefined offset: 1', 'http://serverUrl/uri', 'E_NOTICE');
+            $actual = $this->writerHandler->isExists('file', 1, 'Undefined array key 1', 'http://serverUrl/uri', 'E_WARNING');
             expect($actual)->toBe(false);
 
         });
@@ -142,7 +142,7 @@
             );
             allow(TableGateway::class)->toReceive('selectWith')->with($select)->andReturn($resultSet);
 
-            $actual = $this->writerHandler->isExists('file', 1, 'Undefined offset: 1', 'http://serverUrl/uri', 'E_NOTICE');
+            $actual = $this->writerHandler->isExists('file', 1, 'Undefined array key 1', 'http://serverUrl/uri', 'E_WARNING');
             expect($actual)->toBe(true);
 
         });

diff --git a/spec/Integration/IntegrationViaErrorPreviewControllerForSpecificErrorAndExceptionSpec.php b/spec/Integration/IntegrationViaErrorPreviewControllerForSpecificErrorAndExceptionSpec.php
@@ -58,26 +58,27 @@
 
     });
 
-    describe('/error-preview/notice', function() {
+    describe('/error-preview/warning', function() {
 
         it('empty as rely to original mvc process to handle', function() {
 
             @mkdir(__DIR__ . '/../Fixture/view/error-hero-module/error-preview', 0755, true);
-            file_put_contents(__DIR__ . '/../Fixture/view/error-hero-module/error-preview/notice.phtml', '');
+            file_put_contents(__DIR__ . '/../Fixture/view/error-hero-module/error-preview/warning.phtml', '');
 
             $request     = $this->application->getRequest();
             $request->setMethod('GET');
-            $request->setUri('http://example.com/error-preview/notice');
-            $request->setRequestUri('/error-preview/notice');
+            $request->setUri('http://example.com/error-preview/warning');
+            $request->setRequestUri('/error-preview/warning');
 
             \ob_start();
             $this->application->run();
             $content = \ob_get_clean();
 
             expect(\ob_get_clean())->toBe('');
-            expect($this->application->getResponse()->getStatusCode())->toBe(500);
+            // yes, excluded E_* error means it ignored, means it passed, means it is 200 status code
+            expect($this->application->getResponse()->getStatusCode())->toBe(200);
 
-            unlink(__DIR__ . '/../Fixture/view/error-hero-module/error-preview/notice.phtml');
+            unlink(__DIR__ . '/../Fixture/view/error-hero-module/error-preview/warning.phtml');
             rmdir(__DIR__ . '/../Fixture/view/error-hero-module/error-preview');
             rmdir(__DIR__ . '/../Fixture/view/error-hero-module');
 

diff --git a/src/Controller/ErrorPreviewController.php b/src/Controller/ErrorPreviewController.php
@@ -21,10 +21,10 @@ public function errorAction()
         throw new Error('a sample error preview');
     }
 
-    public function noticeAction()
+    public function warningAction()
     {
         $array = [];
-        $array[1]; // E_NOTICE
+        $array[1]; // E_WARNING
     }
 
     public function fatalAction()