-
-
Notifications
You must be signed in to change notification settings - Fork 163
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
6 changed files
with
306 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
|
||
--- | ||
|
||
## Bug Report | ||
Note that, the bug you're reporting may have registered in the [issues](https://github.com/samchon/typescript-json/search?type=issues) by another user. Even the bug you're reporting may have been fixed in the `@next` version. In such reasons, I recommend you to check the old [issues](https://github.com/samchon/typescript-json/search?type=issues) and reproduct your code with the `@next` version before publishing the bug reporting issue. | ||
|
||
```bash | ||
`npm install --save-dev typescript-json@next` | ||
``` | ||
|
||
When the same error occurs even in the `@next` version, then please fill the below template: | ||
|
||
### Summary | ||
Write a short summary of the bug in here. | ||
|
||
- **SDK Version**: 2.1.0-dev.20220505 | ||
- **Expected behavior**: | ||
- **Actual behavior**: | ||
|
||
Write detailed description in here. | ||
|
||
|
||
|
||
### Code occuring the bug | ||
```typescript | ||
import TSON from "typescript-json"; | ||
|
||
/* Demonstration code occuring the bug you're reporting */ | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
|
||
--- | ||
|
||
## Feature Request | ||
Thanks for your suggestion. Feel free to just state your idea. Writing the issue, it would better to filling the below items: | ||
|
||
- A description of the problem you're trying to solve. | ||
- An overview of the suggested solution. | ||
- Examples of how the suggestion whould work in various places. | ||
- Code examples showing the expected behavior. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
name: Question | ||
about: What do you want to know? | ||
|
||
--- | ||
|
||
## Question | ||
I always welcome any questions about this backend proejct. However, half of questions can be solved by traveling [README.md](https://github.com/samchon/typescript-json) or old [issues](https://github.com/samchon/typescript-json/search?type=issues). Therefore, I recommend you to visit them before. If you have a question that has not been treated and you're extremely urgently, just contact me. | ||
|
||
- E-mail: [email protected] | ||
- Mobile: 82-10-3627-0016 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
Before submitting a Pull Request, please test your code. | ||
|
||
If you created a new created a new feature, then create the unit test function, too. | ||
|
||
```bash | ||
# COMPILE THE BACKEND SERVER | ||
npm run build | ||
|
||
# RUN THE TEST AUTOMATION PROGRAM | ||
npm run test | ||
``` | ||
|
||
Learn more about the [CONTRIBUTING](CONTRIBUTING.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
|
||
# Contributor Covenant Code of Conduct | ||
|
||
## Our Pledge | ||
|
||
We as members, contributors, and leaders pledge to make participation in our | ||
community a harassment-free experience for everyone, regardless of age, body | ||
size, visible or invisible disability, ethnicity, sex characteristics, gender | ||
identity and expression, level of experience, education, socio-economic status, | ||
nationality, personal appearance, race, caste, color, religion, or sexual identity | ||
and orientation. | ||
|
||
We pledge to act and interact in ways that contribute to an open, welcoming, | ||
diverse, inclusive, and healthy community. | ||
|
||
## Our Standards | ||
|
||
Examples of behavior that contributes to a positive environment for our | ||
community include: | ||
|
||
* Demonstrating empathy and kindness toward other people | ||
* Being respectful of differing opinions, viewpoints, and experiences | ||
* Giving and gracefully accepting constructive feedback | ||
* Accepting responsibility and apologizing to those affected by our mistakes, | ||
and learning from the experience | ||
* Focusing on what is best not just for us as individuals, but for the | ||
overall community | ||
|
||
Examples of unacceptable behavior include: | ||
|
||
* The use of sexualized language or imagery, and sexual attention or | ||
advances of any kind | ||
* Trolling, insulting or derogatory comments, and personal or political attacks | ||
* Public or private harassment | ||
* Publishing others' private information, such as a physical or email | ||
address, without their explicit permission | ||
* Other conduct which could reasonably be considered inappropriate in a | ||
professional setting | ||
|
||
## Enforcement Responsibilities | ||
|
||
Community leaders are responsible for clarifying and enforcing our standards of | ||
acceptable behavior and will take appropriate and fair corrective action in | ||
response to any behavior that they deem inappropriate, threatening, offensive, | ||
or harmful. | ||
|
||
Community leaders have the right and responsibility to remove, edit, or reject | ||
comments, commits, code, wiki edits, issues, and other contributions that are | ||
not aligned to this Code of Conduct, and will communicate reasons for moderation | ||
decisions when appropriate. | ||
|
||
## Scope | ||
|
||
This Code of Conduct applies within all community spaces, and also applies when | ||
an individual is officially representing the community in public spaces. | ||
Examples of representing our community include using an official e-mail address, | ||
posting via an official social media account, or acting as an appointed | ||
representative at an online or offline event. | ||
|
||
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported to the community leaders responsible for enforcement at | ||
[INSERT CONTACT METHOD]. | ||
All complaints will be reviewed and investigated promptly and fairly. | ||
|
||
All community leaders are obligated to respect the privacy and security of the | ||
reporter of any incident. | ||
|
||
## Enforcement Guidelines | ||
|
||
Community leaders will follow these Community Impact Guidelines in determining | ||
the consequences for any action they deem in violation of this Code of Conduct: | ||
|
||
### 1. Correction | ||
|
||
**Community Impact**: Use of inappropriate language or other behavior deemed | ||
unprofessional or unwelcome in the community. | ||
|
||
**Consequence**: A private, written warning from community leaders, providing | ||
clarity around the nature of the violation and an explanation of why the | ||
behavior was inappropriate. A public apology may be requested. | ||
|
||
### 2. Warning | ||
|
||
**Community Impact**: A violation through a single incident or series | ||
of actions. | ||
|
||
**Consequence**: A warning with consequences for continued behavior. No | ||
interaction with the people involved, including unsolicited interaction with | ||
those enforcing the Code of Conduct, for a specified period of time. This | ||
includes avoiding interactions in community spaces as well as external channels | ||
like social media. Violating these terms may lead to a temporary or | ||
permanent ban. | ||
|
||
### 3. Temporary Ban | ||
|
||
**Community Impact**: A serious violation of community standards, including | ||
sustained inappropriate behavior. | ||
|
||
**Consequence**: A temporary ban from any sort of interaction or public | ||
communication with the community for a specified period of time. No public or | ||
private interaction with the people involved, including unsolicited interaction | ||
with those enforcing the Code of Conduct, is allowed during this period. | ||
Violating these terms may lead to a permanent ban. | ||
|
||
### 4. Permanent Ban | ||
|
||
**Community Impact**: Demonstrating a pattern of violation of community | ||
standards, including sustained inappropriate behavior, harassment of an | ||
individual, or aggression toward or disparagement of classes of individuals. | ||
|
||
**Consequence**: A permanent ban from any sort of public interaction within | ||
the community. | ||
|
||
## Attribution | ||
|
||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], | ||
version 2.0, available at | ||
[https://www.contributor-covenant.org/version/2/0/code_of_conduct.html][v2.0]. | ||
|
||
Community Impact Guidelines were inspired by | ||
[Mozilla's code of conduct enforcement ladder][Mozilla CoC]. | ||
|
||
For answers to common questions about this code of conduct, see the FAQ at | ||
[https://www.contributor-covenant.org/faq][FAQ]. Translations are available | ||
at [https://www.contributor-covenant.org/translations][translations]. | ||
|
||
[homepage]: https://www.contributor-covenant.org | ||
[v2.0]: https://www.contributor-covenant.org/version/2/0/code_of_conduct.html | ||
[Mozilla CoC]: https://github.com/mozilla/diversity | ||
[FAQ]: https://www.contributor-covenant.org/faq | ||
[translations]: https://www.contributor-covenant.org/translations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
# Contribution Guide | ||
## To Publish an issue | ||
Thanks for your advise. Before publishing an issue, please check some components. | ||
|
||
### 1. Search for duplicates | ||
Before publishing an issue, please check whether the duplicated issue exists or not. | ||
|
||
- [Ordinary Issues](https://github.com/samchon/typescript-json/issues) | ||
|
||
### 2. Did you find a bug? | ||
When you reporting a bug, then please write about those items: | ||
|
||
- What version you're using | ||
- If possible, give me an isolated way to reproduce the behavior. | ||
- The behavior your expect to see, and the actual behavior. | ||
|
||
### 3. Do you have a suggestion? | ||
I always welcome your suggestion. When you publishing a suggestion, then please write such items: | ||
|
||
- A description of the problem you're trying to solve. | ||
- An overview of the suggested solution. | ||
- Examples of how the suggestion whould work in various places. | ||
- Code examples showing the expected behavior. | ||
|
||
|
||
|
||
|
||
## Contributing Code | ||
### Test your code | ||
Before sending a pull request, please test your new code. You type the command `npm run build &&& npm run test`, then compiling your code and test-automation will be all processed. | ||
|
||
```bash | ||
# COMPILE | ||
npm run build | ||
|
||
# DO TEST | ||
npm run test | ||
``` | ||
|
||
If you succeeded to compile, but failed to pass the test-automation, then *debug* the test-automation module. I've configured the `.vscode/launch.json`. You just run the `VSCode` and click the `Start Debugging` button or press `F5` key. By the *debugging*, find the reason why the *test* is failed and fix it. | ||
|
||
### Adding a Test | ||
If you want to add a testing-logic, then goto the `src/test` directory. It's the directory containing the test-automation module. Declare some functions starting from the prefix `test_`. Then, they will be called after the next testing. | ||
|
||
Note that, the special functions starting from the prefix `test_` must be `export`ed. They also must return one of them: | ||
- `void` | ||
- `Promise<void>` | ||
|
||
When you detect an error, then throw exception such below: | ||
|
||
```typescript | ||
import TSON from "../../src"; | ||
import { RandomGenerator } from "../internal/RandomGenerator"; | ||
|
||
export function test_stringify_object_recursive(): void | ||
{ | ||
const department: IDepartment = { | ||
name: RandomGenerator.string(), | ||
parent: { | ||
name: RandomGenerator.string(), | ||
parent: { | ||
name: RandomGenerator.string(), | ||
parent: null | ||
} | ||
} | ||
}; | ||
|
||
const json: string = TSON.stringify<IDepartment>(department); | ||
const expected: string = JSON.stringify(department); | ||
|
||
if (json !== expected) | ||
throw new Error("Bug on TSON.stringify(): failed to understand the recursive object."); | ||
} | ||
|
||
interface IDepartment | ||
{ | ||
name: string; | ||
parent: IDepartment | null; | ||
} | ||
``` | ||
|
||
|
||
|
||
## Sending a Pull Request | ||
Thanks for your contributing. Before sending a pull request to me, please check those components. | ||
|
||
### 1. Include enough descriptions | ||
When you send a pull request, please include a description, of what your change intends to do, on the content. Title, make it clear and simple such below: | ||
|
||
- Refactor features | ||
- Fix #17 | ||
- Add tests for #28 | ||
|
||
### 2. Include adequate tests | ||
As I've mentioned in the `Contributing Code` section, your PR should pass the test-automation module. Your PR includes *new features* that have not being handled in the ordinary test-automation module, then also update *add the testing unit* please. | ||
|
||
If there're some specific reasons that could not pass the test-automation (not error but *intended*), then please update the ordinary test-automation module or write the reasons on your PR content and *const me update the test-automation module*. | ||
|
||
|
||
|
||
|
||
## References | ||
I've referenced contribution guidance of the TypeScript. | ||
- https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md |